[plaso] Changes for running tests with tox #511

[plaso] Changes for running tests with tox #511

[Joachim Metz, 2016-09-24 09:19:35]

Code updated.

[Joachim Metz, 2016-09-24 15:42:19]

Code updated.

[onager, 2016-10-04 13:05:35]

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/bencode_plu...
File tests/parsers/bencode_plugins/transmission.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/bencode_plu...
tests/parsers/bencode_plugins/transmission.py:28: # The older in which
BencodeParser generates events is undeterministic
nondeterministic

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/bencode_plu...
tests/parsers/bencode_plugins/transmission.py:28: # The older in which
BencodeParser generates events is undeterministic
order

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/bencode_plu...
File tests/parsers/bencode_plugins/utorrent.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/bencode_plu...
tests/parsers/bencode_plugins/utorrent.py:28: # The older in which BencodeParser
generates events is undeterministic
order, nondeterministic

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/esedb_plugi...
File tests/parsers/esedb_plugins/msie_webcache.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/esedb_plugi...
tests/parsers/esedb_plugins/msie_webcache.py:26: events =
self._GetSortedEvents(storage_writer.events)
There's no comment here about why the events are sorted, but I actually suspect
that we can drop the comment from the bencode test. Either way, please make sure
this is consistent.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/mactime.py
File tests/parsers/mactime.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/mactime.py#...
tests/parsers/mactime.py:29: # The older in which TextCSVParser generates events
is undeterministic
Same errors as previous similar comments

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
File tests/parsers/plist_plugins/airport.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
tests/parsers/plist_plugins/airport.py:27: # The older in which PlistParser
generates events is undeterministic
See other comments.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
tests/parsers/plist_plugins/airport.py:34: timestamps = sorted([
sorted() seems unnecessary here, the sorting of the events has already done
this.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
File tests/parsers/plist_plugins/appleaccount.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
tests/parsers/plist_plugins/appleaccount.py:29: 
See other comments.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
File tests/parsers/plist_plugins/bluetooth.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
tests/parsers/plist_plugins/bluetooth.py:29: # hence we sort the events.
See other comments.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
File tests/parsers/plist_plugins/default.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
tests/parsers/plist_plugins/default.py:35: # hence we sort the events.
See other comments.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
tests/parsers/plist_plugins/default.py:85: # hence we sort the events.
See other comments.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
File tests/parsers/plist_plugins/install_history.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
tests/parsers/plist_plugins/install_history.py:27: # The older in which
PlistParser generates events is undeterministic
See other comments.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
File tests/parsers/plist_plugins/ipod.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
tests/parsers/plist_plugins/ipod.py:28: # The older in which PlistParser
generates events is undeterministic
See other comments.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
File tests/parsers/plist_plugins/softwareupdate.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
tests/parsers/plist_plugins/softwareupdate.py:28: # hence we sort the events.
See other comments.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
File tests/parsers/plist_plugins/spotlight.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
tests/parsers/plist_plugins/spotlight.py:27: # The older in which PlistParser
generates events is undeterministic
See other comments.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
File tests/parsers/plist_plugins/spotlight_volume.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
tests/parsers/plist_plugins/spotlight_volume.py:28: # hence we sort the events.
See other comments.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
File tests/parsers/plist_plugins/timemachine.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
tests/parsers/plist_plugins/timemachine.py:28: # hence we sort the events.
See other comments.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/test_lib.py
File tests/parsers/test_lib.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/test_lib.py...
tests/parsers/test_lib.py:21: class _EventsHeap(object):
This seems overkill for just sorting events - why aren't you defining __eq__ for
events, or attribute containers? Or even just having an _EventKey method and
using it as an arg for sorted?

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/test_lib.py...
tests/parsers/test_lib.py:22: """Class that defines the events heap."""
-Class that

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/test_lib.py...
tests/parsers/test_lib.py:53: def PushEvent(self, event):
Implement this as Event.__lt__ instead? That's the standard python way of doing
this, and is going to be much more familiar to any other person who knows Python
who encounters this.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/test_lib.py...
tests/parsers/test_lib.py:59: # TODO: replace this work-around for an event
"comparable".
Please open an issue for implementing this.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/test_lib.py...
tests/parsers/test_lib.py:131: """Retrieves the events sorted in a deterministic
order.
-the

[Joachim Metz, 2016-10-04 19:34:16]

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/bencode_plu...
File tests/parsers/bencode_plugins/transmission.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/bencode_plu...
tests/parsers/bencode_plugins/transmission.py:28: # The older in which
BencodeParser generates events is undeterministic
On 2016/10/04 13:05:34, onager wrote:
> order

Done.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/bencode_plu...
tests/parsers/bencode_plugins/transmission.py:28: # The older in which
BencodeParser generates events is undeterministic
On 2016/10/04 13:05:34, onager wrote:
> nondeterministic

Done

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/bencode_plu...
File tests/parsers/bencode_plugins/utorrent.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/bencode_plu...
tests/parsers/bencode_plugins/utorrent.py:28: # The older in which BencodeParser
generates events is undeterministic
On 2016/10/04 13:05:34, onager wrote:
> order, nondeterministic

Done.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/esedb_plugi...
File tests/parsers/esedb_plugins/msie_webcache.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/esedb_plugi...
tests/parsers/esedb_plugins/msie_webcache.py:26: events =
self._GetSortedEvents(storage_writer.events)
I did not add it here because I was not sure if the behavior is related to the
parser in this case. I'll have a look and add a comment.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/mactime.py
File tests/parsers/mactime.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/mactime.py#...
tests/parsers/mactime.py:29: # The older in which TextCSVParser generates events
is undeterministic
On 2016/10/04 13:05:34, onager wrote:
> Same errors as previous similar comments

Done.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
File tests/parsers/plist_plugins/airport.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
tests/parsers/plist_plugins/airport.py:27: # The older in which PlistParser
generates events is undeterministic
On 2016/10/04 13:05:34, onager wrote:
> See other comments.

Done.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
tests/parsers/plist_plugins/airport.py:34: timestamps = sorted([
On 2016/10/04 13:05:34, onager wrote:
> sorted() seems unnecessary here, the sorting of the events has already done
> this.

Done.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
File tests/parsers/plist_plugins/appleaccount.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
tests/parsers/plist_plugins/appleaccount.py:29: 
On 2016/10/04 13:05:34, onager wrote:
> See other comments.

Done.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
File tests/parsers/plist_plugins/bluetooth.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
tests/parsers/plist_plugins/bluetooth.py:29: # hence we sort the events.
On 2016/10/04 13:05:34, onager wrote:
> See other comments.

Done.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
File tests/parsers/plist_plugins/default.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
tests/parsers/plist_plugins/default.py:35: # hence we sort the events.
On 2016/10/04 13:05:34, onager wrote:
> See other comments.

Done.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
tests/parsers/plist_plugins/default.py:85: # hence we sort the events.
On 2016/10/04 13:05:34, onager wrote:
> See other comments.

Done.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
File tests/parsers/plist_plugins/install_history.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
tests/parsers/plist_plugins/install_history.py:27: # The older in which
PlistParser generates events is undeterministic
On 2016/10/04 13:05:34, onager wrote:
> See other comments.

Done.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
File tests/parsers/plist_plugins/ipod.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
tests/parsers/plist_plugins/ipod.py:28: # The older in which PlistParser
generates events is undeterministic
On 2016/10/04 13:05:34, onager wrote:
> See other comments.

Done.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
File tests/parsers/plist_plugins/softwareupdate.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
tests/parsers/plist_plugins/softwareupdate.py:28: # hence we sort the events.
On 2016/10/04 13:05:34, onager wrote:
> See other comments.

Done.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
File tests/parsers/plist_plugins/spotlight.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
tests/parsers/plist_plugins/spotlight.py:27: # The older in which PlistParser
generates events is undeterministic
On 2016/10/04 13:05:34, onager wrote:
> See other comments.

Done.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
File tests/parsers/plist_plugins/spotlight_volume.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
tests/parsers/plist_plugins/spotlight_volume.py:28: # hence we sort the events.
On 2016/10/04 13:05:34, onager wrote:
> See other comments.

Done.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
File tests/parsers/plist_plugins/timemachine.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/plist_plugi...
tests/parsers/plist_plugins/timemachine.py:28: # hence we sort the events.
On 2016/10/04 13:05:34, onager wrote:
> See other comments.

Done.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/test_lib.py
File tests/parsers/test_lib.py (right):

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/test_lib.py...
tests/parsers/test_lib.py:21: class _EventsHeap(object):
Agree but keeping this par with storage for now and planning to fix this after
the event data changes.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/test_lib.py...
tests/parsers/test_lib.py:22: """Class that defines the events heap."""
On 2016/10/04 13:05:34, onager wrote:
> -Class that

Done.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/test_lib.py...
tests/parsers/test_lib.py:53: def PushEvent(self, event):
see comment of comparable, that is something I think we need to do after event
data changes.

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/test_lib.py...
tests/parsers/test_lib.py:59: # TODO: replace this work-around for an event
"comparable".
On 2016/10/04 13:05:34, onager wrote:
> Please open an issue for implementing this.
https://github.com/log2timeline/plaso/issues/1028

https://codereview.appspot.com/305530043/diff/40001/tests/parsers/test_lib.py...
tests/parsers/test_lib.py:131: """Retrieves the events sorted in a deterministic
order.
On 2016/10/04 13:05:34, onager wrote:
> -the

Done.

[Joachim Metz, 2016-10-04 19:51:45]

Code updated.

[onager, 2016-10-04 20:24:33]

LGTM

[Joachim Metz, 2016-10-05 03:48:58]

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close tox