Issue 305300043: [plaso] Set utf-8 encoding for syslog. Fixes for #945 and #946

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 305300043: [plaso] Set utf-8 encoding for syslog. Fixes for #945 and #946 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 8 months ago by onager

Modified:
7 years, 8 months ago

Reviewers:
Joachim Metz, onager

CC:
kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

[plaso] Set utf-8 encoding for syslog. Fixes for #945 and #946

Patch Set 1 #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -5 lines)			Patch
M	plaso/parsers/syslog.py	View	2 chunks	+10 lines, -2 lines	1 comment	Download
M	test_data/syslog	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/parsers/syslog.py	View	2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Joachim Metz

LGTM, small nits https://codereview.appspot.com/305300043/diff/1/plaso/parsers/syslog.py File plaso/parsers/syslog.py (right): https://codereview.appspot.com/305300043/diff/1/plaso/parsers/syslog.py#newcode36 plaso/parsers/syslog.py:36: _reporter_characters = u''.join( Please add a ...

7 years, 8 months ago (2016-08-23 14:03:14 UTC) #2

onager

7 years, 8 months ago (2016-08-23 15:20:29 UTC) #3

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close fix_syslog

Expand All Messages | Collapse All Messages