Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2960)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 304440043: [plaso] Migrated plaso timestamp to dfdatetime #910 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by Joachim Metz
Modified:
7 years ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Migrated plaso timestamp to dfdatetime #910 Depends on: https://codereview.appspot.com/318190043/ https://codereview.appspot.com/319930043

Patch Set 1 : Worked on dfDateTime support. #

Patch Set 2 : Migrated plaso timestamp to dfdatetime #910 #

Patch Set 3 : Migrated plaso timestamp to dfdatetime #910 #

Total comments: 38

Patch Set 4 : Changes after review #

Patch Set 5 : Changes after review #

Patch Set 6 : Changes after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7042 lines, -6588 lines) Patch
M plaso/cli/storage_media_tool.py View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M plaso/containers/file_system_events.py View 1 1 chunk +0 lines, -134 lines 0 comments Download
M plaso/containers/plist_event.py View 1 3 chunks +30 lines, -39 lines 0 comments Download
M plaso/containers/shell_item_events.py View 1 1 chunk +28 lines, -17 lines 0 comments Download
D plaso/containers/text_events.py View 1 1 chunk +0 lines, -35 lines 0 comments Download
M plaso/containers/time_events.py View 1 2 3 1 chunk +0 lines, -202 lines 0 comments Download
M plaso/containers/windows_events.py View 1 2 3 4 3 chunks +39 lines, -37 lines 0 comments Download
M plaso/formatters/chrome_preferences.py View 1 2 chunks +59 lines, -6 lines 0 comments Download
M plaso/formatters/interface.py View 1 3 chunks +13 lines, -5 lines 0 comments Download
M plaso/formatters/mac_appfirewall.py View 1 1 chunk +1 line, -1 line 0 comments Download
M plaso/formatters/mac_securityd.py View 1 2 chunks +4 lines, -4 lines 0 comments Download
M plaso/formatters/olecf.py View 1 5 chunks +6 lines, -6 lines 0 comments Download
M plaso/formatters/pls_recall.py View 1 1 chunk +13 lines, -6 lines 0 comments Download
M plaso/formatters/sccm.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M plaso/lib/eventdata.py View 1 1 chunk +3 lines, -0 lines 0 comments Download
M plaso/lib/timelib.py View 1 5 chunks +0 lines, -299 lines 0 comments Download
M plaso/parsers/android_app_usage.py View 1 5 chunks +27 lines, -24 lines 0 comments Download
M plaso/parsers/asl.py View 1 7 chunks +84 lines, -89 lines 0 comments Download
M plaso/parsers/bash_history.py View 1 2 3 3 chunks +30 lines, -23 lines 0 comments Download
M plaso/parsers/bencode_parser.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M plaso/parsers/bencode_plugins/interface.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M plaso/parsers/bencode_plugins/transmission.py View 1 2 chunks +43 lines, -36 lines 0 comments Download
M plaso/parsers/bencode_plugins/utorrent.py View 1 5 chunks +38 lines, -32 lines 0 comments Download
M plaso/parsers/bsm.py View 1 29 chunks +342 lines, -270 lines 0 comments Download
M plaso/parsers/chrome_cache.py View 1 15 chunks +57 lines, -53 lines 0 comments Download
M plaso/parsers/chrome_preferences.py View 1 5 chunks +153 lines, -124 lines 0 comments Download
M plaso/parsers/cookie_plugins/ganalytics.py View 1 6 chunks +85 lines, -69 lines 0 comments Download
M plaso/parsers/cups_ipp.py View 1 4 chunks +104 lines, -82 lines 0 comments Download
M plaso/parsers/custom_destinations.py View 1 2 chunks +10 lines, -8 lines 0 comments Download
M plaso/parsers/docker.py View 1 7 chunks +120 lines, -98 lines 0 comments Download
M plaso/parsers/dpkg.py View 1 4 chunks +24 lines, -47 lines 0 comments Download
M plaso/parsers/esedb.py View 1 2 chunks +7 lines, -2 lines 0 comments Download
M plaso/parsers/esedb_plugins/file_history.py View 1 3 chunks +36 lines, -40 lines 0 comments Download
M plaso/parsers/esedb_plugins/interface.py View 1 3 chunks +7 lines, -4 lines 0 comments Download
M plaso/parsers/esedb_plugins/msie_webcache.py View 1 12 chunks +128 lines, -175 lines 0 comments Download
M plaso/parsers/filestat.py View 1 4 chunks +43 lines, -7 lines 0 comments Download
M plaso/parsers/firefox_cache.py View 1 9 chunks +129 lines, -92 lines 0 comments Download
M plaso/parsers/iis.py View 1 5 chunks +148 lines, -130 lines 0 comments Download
M plaso/parsers/interface.py View 1 5 chunks +5 lines, -5 lines 0 comments Download
M plaso/parsers/java_idx.py View 1 3 chunks +34 lines, -33 lines 0 comments Download
M plaso/parsers/mac_appfirewall.py View 1 6 chunks +116 lines, -88 lines 0 comments Download
M plaso/parsers/mac_keychain.py View 1 9 chunks +254 lines, -221 lines 0 comments Download
M plaso/parsers/mac_securityd.py View 1 5 chunks +122 lines, -105 lines 0 comments Download
M plaso/parsers/mac_wifi.py View 1 2 3 7 chunks +158 lines, -129 lines 0 comments Download
M plaso/parsers/mactime.py View 1 5 chunks +34 lines, -41 lines 0 comments Download
M plaso/parsers/mcafeeav.py View 1 4 chunks +47 lines, -28 lines 0 comments Download
M plaso/parsers/msiecf.py View 1 6 chunks +236 lines, -213 lines 0 comments Download
M plaso/parsers/ntfs.py View 1 2 3 15 chunks +169 lines, -65 lines 0 comments Download
M plaso/parsers/olecf.py View 1 4 chunks +35 lines, -22 lines 0 comments Download
M plaso/parsers/olecf_plugins/automatic_destinations.py View 1 10 chunks +107 lines, -80 lines 0 comments Download
M plaso/parsers/olecf_plugins/default.py View 1 3 chunks +46 lines, -53 lines 0 comments Download
M plaso/parsers/olecf_plugins/interface.py View 1 2 chunks +11 lines, -60 lines 0 comments Download
M plaso/parsers/olecf_plugins/summary.py View 1 2 3 4 chunks +244 lines, -273 lines 0 comments Download
M plaso/parsers/opera.py View 1 5 chunks +188 lines, -167 lines 0 comments Download
M plaso/parsers/oxml.py View 1 4 chunks +115 lines, -56 lines 0 comments Download
M plaso/parsers/pcap.py View 1 3 chunks +86 lines, -40 lines 0 comments Download
M plaso/parsers/pe.py View 1 10 chunks +79 lines, -137 lines 0 comments Download
M plaso/parsers/plist.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M plaso/parsers/plist_plugins/airport.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M plaso/parsers/plist_plugins/appleaccount.py View 1 2 chunks +5 lines, -3 lines 0 comments Download
M plaso/parsers/plist_plugins/bluetooth.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M plaso/parsers/plist_plugins/default.py View 1 2 chunks +4 lines, -2 lines 0 comments Download
M plaso/parsers/plist_plugins/install_history.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M plaso/parsers/plist_plugins/interface.py View 1 2 chunks +5 lines, -3 lines 0 comments Download
M plaso/parsers/plist_plugins/ipod.py View 1 2 chunks +34 lines, -34 lines 0 comments Download
M plaso/parsers/plist_plugins/macuser.py View 1 5 chunks +62 lines, -42 lines 0 comments Download
M plaso/parsers/plist_plugins/safari.py View 1 2 chunks +56 lines, -36 lines 0 comments Download
M plaso/parsers/plist_plugins/softwareupdate.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M plaso/parsers/plist_plugins/spotlight.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M plaso/parsers/plist_plugins/spotlight_volume.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M plaso/parsers/plist_plugins/timemachine.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M plaso/parsers/pls_recall.py View 1 8 chunks +47 lines, -44 lines 0 comments Download
M plaso/parsers/popcontest.py View 1 3 chunks +77 lines, -74 lines 0 comments Download
M plaso/parsers/recycler.py View 1 7 chunks +118 lines, -84 lines 0 comments Download
M plaso/parsers/safari_cookies.py View 1 2 3 3 chunks +44 lines, -39 lines 0 comments Download
M plaso/parsers/sccm.py View 1 2 3 5 chunks +44 lines, -17 lines 0 comments Download
M plaso/parsers/selinux.py View 1 4 chunks +27 lines, -30 lines 0 comments Download
M plaso/parsers/shared/shell_items.py View 1 7 chunks +34 lines, -24 lines 0 comments Download
M plaso/parsers/skydrivelog.py View 1 2 3 4 chunks +246 lines, -269 lines 0 comments Download
M plaso/parsers/sqlite.py View 1 1 chunk +1 line, -1 line 0 comments Download
M plaso/parsers/sqlite_plugins/firefox.py View 1 9 chunks +221 lines, -198 lines 0 comments Download
M plaso/parsers/sqlite_plugins/skype.py View 1 1 chunk +1 line, -1 line 0 comments Download
M plaso/parsers/symantec.py View 1 4 chunks +225 lines, -28 lines 0 comments Download
M plaso/parsers/syslog.py View 1 2 3 4 5 3 chunks +75 lines, -27 lines 0 comments Download
M plaso/parsers/syslog_plugins/cron.py View 1 2 3 4 5 2 chunks +40 lines, -12 lines 0 comments Download
M plaso/parsers/syslog_plugins/ssh.py View 1 2 3 4 5 3 chunks +81 lines, -35 lines 0 comments Download
M plaso/parsers/text_parser.py View 1 2 3 4 chunks +54 lines, -20 lines 0 comments Download
M plaso/parsers/utmp.py View 1 5 chunks +133 lines, -126 lines 0 comments Download
M plaso/parsers/utmpx.py View 1 9 chunks +48 lines, -48 lines 0 comments Download
M plaso/parsers/winevt.py View 1 9 chunks +111 lines, -76 lines 0 comments Download
M plaso/parsers/winevtx.py View 1 7 chunks +114 lines, -78 lines 0 comments Download
M plaso/parsers/winfirewall.py View 1 2 3 3 chunks +135 lines, -87 lines 0 comments Download
M plaso/parsers/winjob.py View 1 6 chunks +90 lines, -136 lines 0 comments Download
M plaso/parsers/winlnk.py View 1 4 chunks +122 lines, -92 lines 0 comments Download
M plaso/parsers/winprefetch.py View 1 8 chunks +58 lines, -52 lines 0 comments Download
M plaso/parsers/winreg_plugins/ccleaner.py View 1 5 chunks +85 lines, -38 lines 0 comments Download
M plaso/parsers/winrestore.py View 1 2 chunks +50 lines, -82 lines 0 comments Download
M plaso/parsers/xchatlog.py View 1 2 3 4 chunks +158 lines, -119 lines 0 comments Download
M plaso/parsers/xchatscrollback.py View 1 5 chunks +73 lines, -76 lines 0 comments Download
M plaso/parsers/zsh_extended_history.py View 1 3 chunks +32 lines, -34 lines 0 comments Download
M plaso/serializer/json_serializer.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/analysis/viper.py View 1 2 3 2 chunks +11 lines, -3 lines 0 comments Download
M tests/analysis/virustotal.py View 1 2 3 2 chunks +11 lines, -3 lines 0 comments Download
M tests/containers/test_lib.py View 1 2 chunks +11 lines, -9 lines 0 comments Download
M tests/formatters/bash_history.py View 1 2 3 2 chunks +12 lines, -5 lines 0 comments Download
M tests/formatters/chrome_preferences.py View 1 1 chunk +5 lines, -0 lines 0 comments Download
M tests/formatters/dpkg.py View 1 2 chunks +13 lines, -7 lines 0 comments Download
M tests/formatters/mac_wifi.py View 1 2 3 3 chunks +24 lines, -14 lines 0 comments Download
M tests/formatters/manager.py View 1 1 chunk +4 lines, -4 lines 0 comments Download
M tests/formatters/olecf.py View 1 4 chunks +12 lines, -12 lines 0 comments Download
M tests/formatters/pls_recall.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/formatters/zsh_extended_history.py View 1 2 3 2 chunks +13 lines, -5 lines 0 comments Download
M tests/lib/timelib.py View 1 4 chunks +0 lines, -137 lines 0 comments Download
M tests/parsers/bsm.py View 1 7 chunks +30 lines, -29 lines 0 comments Download
M tests/parsers/chrome_preferences.py View 1 6 chunks +27 lines, -28 lines 0 comments Download
M tests/parsers/cookie_plugins/ganalytics.py View 1 6 chunks +33 lines, -34 lines 0 comments Download
M tests/parsers/esedb_plugins/file_history.py View 1 1 chunk +15 lines, -12 lines 0 comments Download
M tests/parsers/mac_keychain.py View 1 2 chunks +4 lines, -5 lines 0 comments Download
M tests/parsers/mac_wifi.py View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M tests/parsers/mcafeeav.py View 1 4 chunks +19 lines, -11 lines 0 comments Download
M tests/parsers/msiecf.py View 1 2 chunks +5 lines, -5 lines 0 comments Download
M tests/parsers/olecf.py View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tests/parsers/olecf_plugins/automatic_destinations.py View 1 3 chunks +7 lines, -7 lines 0 comments Download
M tests/parsers/olecf_plugins/default.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/parsers/olecf_plugins/summary.py View 1 2 chunks +9 lines, -9 lines 0 comments Download
M tests/parsers/olecf_plugins/test_lib.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/parsers/plist_plugins/ipod.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/pls_recall.py View 1 1 chunk +15 lines, -22 lines 0 comments Download
M tests/parsers/recycler.py View 1 4 chunks +19 lines, -22 lines 0 comments Download
M tests/parsers/safari_cookies.py View 1 2 chunks +19 lines, -19 lines 0 comments Download
M tests/parsers/syslog_plugins/cron.py View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M tests/parsers/syslog_plugins/ssh.py View 1 2 3 chunks +4 lines, -7 lines 0 comments Download
M tests/parsers/test_lib.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/winlnk.py View 1 5 chunks +31 lines, -31 lines 0 comments Download
M tests/parsers/xchatlog.py View 1 1 chunk +21 lines, -21 lines 0 comments Download
M tests/storage/test_lib.py View 1 2 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 26
Joachim Metz
7 years, 8 months ago (2016-08-14 08:33:07 UTC) #1
Joachim Metz
Code updated.
7 years, 8 months ago (2016-08-14 14:43:09 UTC) #2
Joachim Metz
Code updated.
7 years, 8 months ago (2016-08-14 18:39:53 UTC) #3
Joachim Metz
Code updated.
7 years, 8 months ago (2016-08-15 06:18:16 UTC) #4
Joachim Metz
Code updated.
7 years, 8 months ago (2016-08-18 06:45:30 UTC) #5
Joachim Metz
Code updated.
7 years, 7 months ago (2016-08-27 15:14:04 UTC) #6
Joachim Metz
Code updated.
7 years, 6 months ago (2016-09-24 09:44:38 UTC) #7
Joachim Metz
Code updated.
7 years, 6 months ago (2016-10-02 12:12:34 UTC) #8
Joachim Metz
Code updated.
7 years, 6 months ago (2016-10-02 16:49:38 UTC) #9
Joachim Metz
Code updated.
7 years, 6 months ago (2016-10-03 05:53:29 UTC) #10
Joachim Metz
Code updated.
7 years, 5 months ago (2016-11-02 18:52:35 UTC) #11
Joachim Metz
Code updated.
7 years, 5 months ago (2016-11-07 16:07:19 UTC) #12
Joachim Metz
Code updated.
7 years, 3 months ago (2016-12-25 16:37:11 UTC) #13
Joachim Metz
Code updated.
7 years, 3 months ago (2016-12-28 20:05:13 UTC) #14
Joachim Metz
Code updated.
7 years, 3 months ago (2016-12-30 16:20:54 UTC) #15
Joachim Metz
Code updated.
7 years, 3 months ago (2017-01-01 09:54:32 UTC) #16
Joachim Metz
Code updated.
7 years, 3 months ago (2017-01-03 07:49:46 UTC) #17
onager
https://codereview.appspot.com/304440043/diff/310001/plaso/containers/windows_events.py File plaso/containers/windows_events.py (right): https://codereview.appspot.com/304440043/diff/310001/plaso/containers/windows_events.py#newcode2 plaso/containers/windows_events.py:2: """This file contains the Windows specific event object classes.""" ...
7 years, 1 month ago (2017-02-28 14:01:52 UTC) #18
Joachim Metz
https://codereview.appspot.com/304440043/diff/310001/plaso/containers/windows_events.py File plaso/containers/windows_events.py (right): https://codereview.appspot.com/304440043/diff/310001/plaso/containers/windows_events.py#newcode2 plaso/containers/windows_events.py:2: """This file contains the Windows specific event object classes.""" ...
7 years, 1 month ago (2017-03-11 11:33:14 UTC) #19
Joachim Metz
Code updated.
7 years, 1 month ago (2017-03-11 13:11:04 UTC) #20
Joachim Metz
Code updated.
7 years, 1 month ago (2017-03-11 13:18:44 UTC) #21
onager
One nit, LGTM https://codereview.appspot.com/304440043/diff/310001/plaso/parsers/syslog_plugins/cron.py File plaso/parsers/syslog_plugins/cron.py (right): https://codereview.appspot.com/304440043/diff/310001/plaso/parsers/syslog_plugins/cron.py#newcode13 plaso/parsers/syslog_plugins/cron.py:13: class CronTaskRunEventData(events.EventData): On 2017/03/11 11:33:14, Joachim ...
7 years ago (2017-03-24 10:47:18 UTC) #22
Joachim Metz
Code updated.
7 years ago (2017-03-25 09:05:42 UTC) #23
Joachim Metz
https://codereview.appspot.com/304440043/diff/310001/plaso/parsers/syslog_plugins/cron.py File plaso/parsers/syslog_plugins/cron.py (right): https://codereview.appspot.com/304440043/diff/310001/plaso/parsers/syslog_plugins/cron.py#newcode13 plaso/parsers/syslog_plugins/cron.py:13: class CronTaskRunEventData(events.EventData): On 2017/03/24 10:47:18, onager wrote: > On ...
7 years ago (2017-03-25 09:33:23 UTC) #24
Joachim Metz
Code updated.
7 years ago (2017-03-25 09:49:49 UTC) #25
Joachim Metz
7 years ago (2017-03-25 10:04:15 UTC) #26 
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close dfdatetime
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b