Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1124)

Issue 304260043: Issue 4947: Link notes to dynamics in Dynamic_performer rather than Staff_performer. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by Dan Eble
Modified:
7 years, 8 months ago
Reviewers:
ht
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Link notes to dynamics in Dynamic_performer rather than Staff_performer. This makes dynamics in different voices independent of each other. This was mentioned in https://codereview.appspot.com/302930043/ . I doubt that the two new regression tests are very valuable. If it hadn't been for the previous implementation, I probably would not have thought to create them. Please vote on whether I should include or omit them when it comes time to push.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -38 lines) Patch
A input/regression/midi/dynamic-voices-sequential.ly View 1 chunk +15 lines, -0 lines 0 comments Download
A input/regression/midi/dynamic-voices-simultaneous.ly View 1 chunk +15 lines, -0 lines 0 comments Download
M lily/dynamic-performer.cc View 4 chunks +25 lines, -0 lines 0 comments Download
M lily/staff-performer.cc View 5 chunks +0 lines, -38 lines 0 comments Download

Messages

Total messages: 2
Dan Eble
7 years, 8 months ago (2016-07-30 19:37:43 UTC) #1
ht
7 years, 8 months ago (2016-08-04 20:53:47 UTC) #2
It indeed seems much more logical to associate the Audio_span_dynamic of each
note in Dynamic_performer rather than Staff_performer, and avoid the side
effects caused by identifying Voices by their name in Staff_performer (in the
corner case of identically named Voices).

(I don't really have a strong opinion about whether these side effects could
have originally been intentional or not [as sharing dynamics between Voices
could even have its uses] since, taken in isolation, the previous
Staff_performer code doesn't give any obvious clues about this either way.  As
there are other developers who think the previous behavior is a bug, however, I
have nothing against fixing the behavior like this, and will simplify the
documentation patch issue 4920 accordingly.)

Having regression tests for this functionality could be useful to document the
intended behavior after this change (and might be helpful to anyone trying to
understand the design behind the implementation later).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b