Issue 304210043: [dfwinreg] Added update dependencies script and dependencies tests.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 304210043: [dfwinreg] Added update dependencies script and dependencies tests. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 9 months ago by Joachim Metz

Modified:
7 years, 9 months ago

Reviewers:
onager

CC:
kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

[dfwinreg] Added update dependencies script and dependencies tests.

Patch Set 1 : Added update dependencies script and dependencies tests. #

Total comments: 2

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+623 lines, -142 lines)			Patch
M	.travis.yml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	config/dpkg/control	View	2 chunks	+4 lines, -5 lines	0 comments	Download
A	config/travis/before_install.sh	View	1 chunk	+19 lines, -0 lines	0 comments	Download
M	dfwinreg/dependencies.py	View	7 chunks	+251 lines, -127 lines	0 comments	Download
M	setup.cfg	View	1 chunk	+5 lines, -5 lines	0 comments	Download
A	tests/dependencies.py	View	1 chunk	+113 lines, -0 lines	0 comments	Download
M	tox.ini	View	1 chunk	+6 lines, -4 lines	0 comments	Download
A	utils/update_dependencies.py	View	1 chunk	+224 lines, -0 lines	2 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

onager

LGTM, one nit. https://codereview.appspot.com/304210043/diff/20001/utils/update_dependencies.py File utils/update_dependencies.py (right): https://codereview.appspot.com/304210043/diff/20001/utils/update_dependencies.py#newcode20 utils/update_dependencies.py:20: u'Log2Timeline developers <log2timeline-dev@googlegroups.com>') log2timeline maintainers

7 years, 9 months ago (2016-07-25 11:57:38 UTC) #3

Joachim Metz

https://codereview.appspot.com/304210043/diff/20001/utils/update_dependencies.py File utils/update_dependencies.py (right): https://codereview.appspot.com/304210043/diff/20001/utils/update_dependencies.py#newcode20 utils/update_dependencies.py:20: u'Log2Timeline developers <log2timeline-dev@googlegroups.com>') On 2016/07/25 11:57:38, onager wrote: > ...

7 years, 9 months ago (2016-07-25 16:04:14 UTC) #4

Joachim Metz

7 years, 9 months ago (2016-07-25 16:16:28 UTC) #5

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close dependencies

Expand All Messages | Collapse All Messages