Issue 303390043: TBR: i#1988: fix nop padding bug with MPX prefixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 303390043: TBR: i#1988: fix nop padding bug with MPX prefixes

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 8 months ago by bruening

Modified:
7 years, 8 months ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1988: fix nop padding bug with MPX prefixes Adds elimination of MPX prefixes from jumps during mangling (they're removed later anyway) to avoid messing up nop padding calculations. To support MPX we'll have to put in support for prefixes on ctis but that's for the future. Fixes #1988 ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	core/arch/mangle_shared.c	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	core/arch/x86/mangle.c	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

7 years, 8 months ago (2016-08-24 05:24:27 UTC) #2

Committed as
https://github.com/DynamoRIO/dynamorio/commit/99530cac43e3d4bbad452baf8efe3af...

Final commit log: 
---------------
i#1988: fix nop padding bug with MPX prefixes

Adds elimination of MPX prefixes from jumps during mangling (they're
removed later anyway) to avoid messing up nop padding calculations.
To support MPX we'll have to put in support for prefixes on ctis but
that's for the future.

Fixes #1988

Review-URL: https://codereview.appspot.com/303390043
---------------

Expand All Messages | Collapse All Messages