Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5130)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 303200043: [plaso] Various changes to Windows job file parser #864 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by Joachim Metz
Modified:
7 years, 8 months ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Various changes to Windows job file parser #864

Patch Set 1 #

Total comments: 5

Patch Set 2 : Changes after review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -156 lines) Patch
M plaso/containers/time_events.py View 1 12 chunks +12 lines, -12 lines 0 comments Download
M plaso/formatters/winjob.py View 2 chunks +7 lines, -7 lines 0 comments Download
M plaso/parsers/winjob.py View 1 7 chunks +176 lines, -122 lines 0 comments Download
M tests/formatters/winjob.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/parsers/winjob.py View 2 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 7
Joachim Metz
7 years, 8 months ago (2016-07-28 18:23:06 UTC) #1
Joachim Metz
https://codereview.appspot.com/303200043/diff/1/plaso/parsers/recycler.py File plaso/parsers/recycler.py (left): https://codereview.appspot.com/303200043/diff/1/plaso/parsers/recycler.py#oldcode25 plaso/parsers/recycler.py:25: filetime: the FILETIME timestamp value. leakage ignore
7 years, 8 months ago (2016-07-28 18:23:49 UTC) #2
onager
https://codereview.appspot.com/303200043/diff/1/plaso/parsers/winjob.py File plaso/parsers/winjob.py (right): https://codereview.appspot.com/303200043/diff/1/plaso/parsers/winjob.py#newcode40 plaso/parsers/winjob.py:40: timestamp_description (str): description of the usage of the timestamp ...
7 years, 8 months ago (2016-07-29 09:58:56 UTC) #3
Joachim Metz
https://codereview.appspot.com/303200043/diff/1/plaso/parsers/winjob.py File plaso/parsers/winjob.py (right): https://codereview.appspot.com/303200043/diff/1/plaso/parsers/winjob.py#newcode40 plaso/parsers/winjob.py:40: timestamp_description (str): description of the usage of the timestamp ...
7 years, 8 months ago (2016-07-30 07:42:16 UTC) #4
Joachim Metz
Code updated.
7 years, 8 months ago (2016-07-30 07:44:17 UTC) #5
onager
LGTM
7 years, 8 months ago (2016-07-30 09:26:58 UTC) #6
Joachim Metz
7 years, 8 months ago (2016-07-31 06:16:57 UTC) #7 
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close fix864
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b