Issue 302590043: TBR: i#1987 Win10-1607: update winsysnums to find split usercalls

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 302590043: TBR: i#1987 Win10-1607: update winsysnums to find split usercalls

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 8 months ago by bruening

Modified:
7 years, 8 months ago

Reviewers:
zhaoqin

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1987 Win10-1607: update winsysnums to find split usercalls Win10-1607 moves win32k.sys syscall wrappers to a new library, win32u.dll. This means that winsysnums -usercalls needs to look at user32.dll routines invoking imports rather than raw syscalls, with additional complexity of two of the targets using a "Local_" direct call that indirectly gets to the import through other stub layers rather than a direct import. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -8 lines)			Patch
	M	clients/standalone/winsysnums.c	View		5 chunks	+76 lines, -8 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bruening

7 years, 8 months ago (2016-08-24 05:23:49 UTC) #2

Committed as
https://github.com/DynamoRIO/dynamorio/commit/9b7e44eb94019f2cbd8e6b845cb9b06...

Final commit log: 
---------------
i#1987 Win10-1607: update winsysnums to find split usercalls

Win10-1607 moves win32k.sys syscall wrappers to a new library,
win32u.dll.  This means that winsysnums -usercalls needs to look at
user32.dll routines invoking imports rather than raw syscalls, with
additional complexity of two of the targets using a "Local_" direct
call that indirectly gets to the import through other stub layers
rather than a direct import.

Review-URL: https://codereview.appspot.com/302590043
---------------

Expand All Messages | Collapse All Messages