Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(772)

Issue 302000043: Issue 4902: Improve `-dgs-load-fonts` option for TTF that doesn't have glyph names

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by trueroad
Modified:
7 years, 10 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 4902/2: Improve `-dgs-load-fonts` option for TTF `-dgs-load-fonts` loads fonts via Ghostscript. However, if a TrueType font (TTF) that does not have glyph names is loaded via Ghostscript, all characters are shown in TOFU. This commit lets `-dgs-load-fonts` loads those fonts in a way that is not via Ghostscript. Issue 4902/1: Add procedure `ly:has-glyph-names?` This commit adds procedure `ly:has-glyph-names?` to check whether or not a font has glyph names. *This patch requires Issue 4900 and Issue 4901.* https://codereview.appspot.com/301990043 https://codereview.appspot.com/299360043

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use FT_HAS_GLYPH_NAMES #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1 line) Patch
M lily/open-type-font-scheme.cc View 1 1 chunk +46 lines, -0 lines 0 comments Download
M scm/framework-ps.scm View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 4
lemzwerg
LGTM. https://codereview.appspot.com/302000043/diff/1/lily/open-type-font-scheme.cc File lily/open-type-font-scheme.cc (right): https://codereview.appspot.com/302000043/diff/1/lily/open-type-font-scheme.cc#newcode216 lily/open-type-font-scheme.cc:216: bool has_glyph_names = face->face_flags & FT_FACE_FLAG_GLYPH_NAMES; bool has_glyph_names ...
7 years, 10 months ago (2016-06-19 18:49:53 UTC) #1
trueroad
Use FT_HAS_GLYPH_NAMES
7 years, 10 months ago (2016-06-19 22:02:48 UTC) #2
trueroad
Thank you for your reviewing. https://codereview.appspot.com/302000043/diff/1/lily/open-type-font-scheme.cc File lily/open-type-font-scheme.cc (right): https://codereview.appspot.com/302000043/diff/1/lily/open-type-font-scheme.cc#newcode216 lily/open-type-font-scheme.cc:216: bool has_glyph_names = face->face_flags ...
7 years, 10 months ago (2016-06-19 22:05:07 UTC) #3
trueroad
7 years, 10 months ago (2016-06-27 14:59:18 UTC) #4
I've pushed to staging.

Issue 4902/1: Add procedure `ly:has-glyph-names?`
commit 9437884ac32029c7166ab54cb4f727232b7cdc3c

Issue 4902/2: Improve `-dgs-load-fonts` option for TTF
commit b060b5bac8cb49ab80f6ea31410725340423e6f7
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b