Issue 301420043: Fixes a TypeError on None in the solver.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 301420043: Fixes a TypeError on None in the solver. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 9 months ago by the80srobot

Modified:
7 years, 8 months ago

Reviewers:
Joachim Metz

CC:
rekall-dev_googlegroups.com

Base URL:
git@github.com:google/dotty.git@master

Visibility:
Public.

More Reviews

Description

Fixes a TypeError on None in the solver. BUG= R=joachim.metz@gmail.com Committed: ee0f320c95bc978e911313ecc7dd7d0db1ea10c2

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -1 line)			Patch
	M	efilter/transforms/solve.py	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
	M	efilter_tests/unit/transforms/solve.py	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

Joachim Metz

Please have a look at: https://github.com/log2timeline/plaso/issues/820 the issue is that 'None' in the filter below ...

7 years, 9 months ago (2016-07-23 07:59:58 UTC) #2

Joachim Metz

For context https://github.com/google/dotty/blob/master/sample_projects/tagging/tag.py#L144 https://github.com/log2timeline/plaso/blob/5dab93e2b4dcf9545181f75906c0b5d5f4e9b615/plaso/analysis/tagging.py#L207

7 years, 9 months ago (2016-07-23 08:03:25 UTC) #3

Joachim Metz

https://codereview.appspot.com/301420043/diff/1/efilter/transforms/solve.py File efilter/transforms/solve.py (right): https://codereview.appspot.com/301420043/diff/1/efilter/transforms/solve.py#newcode160 efilter/transforms/solve.py:160: EfilterTypeError if the values don't conform. + EfilterNoneError

7 years, 9 months ago (2016-07-23 08:05:03 UTC) #4

the80srobot

Ah. My bad, I misunderstood both the problem and the fact that None is actually ...

7 years, 9 months ago (2016-07-25 07:17:19 UTC) #5

the80srobot

7 years, 8 months ago (2016-07-26 10:35:28 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
ee0f320c95bc978e911313ecc7dd7d0db1ea10c2 (presubmit successful).

Expand All Messages | Collapse All Messages