Issue 300550043: i#1569 AArch64: Remove REG_X31_INVALID, and remove XZR from GPR range.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 300550043: i#1569 AArch64: Remove REG_X31_INVALID, and remove XZR from GPR range. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 9 months ago by Edmund.Grimley.Evans

Modified:
7 years, 9 months ago

Reviewers:
bruening

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1569 AArch64: Remove REG_X31_INVALID, and remove XZR from GPR range. Likewise for W31 and WZR. So DR_NUM_GPR_REGS is now 32 again, and the real registers, that can hold data, are contiguous. ---------------

Patch Set 1 #

Total comments: 1

Patch Set 2 : Committed #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -11 lines)			Patch
	M	core/arch/aarch64/encode.c	View		2 chunks	+6 lines, -6 lines	0 comments	Download
	M	core/arch/opnd.h	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bruening

LGTM w/ comment https://codereview.appspot.com/300550043/diff/1/core/arch/opnd.h File core/arch/opnd.h (right): https://codereview.appspot.com/300550043/diff/1/core/arch/opnd.h#newcode197 core/arch/opnd.h:197: DR_REG_XZR, /* zero register */ Please ...

7 years, 9 months ago (2016-07-01 17:36:12 UTC) #2

Edmund.Grimley.Evans

7 years, 9 months ago (2016-07-04 08:37:11 UTC) #3

Committed as
https://github.com/DynamoRIO/dynamorio/commit/f038052acf9904959ccf7bcb4c9064c...

Final commit log: 
---------------
i#1569 AArch64: Remove REG_X31_INVALID, and remove XZR from GPR range.

Likewise for W31 and WZR. So DR_NUM_GPR_REGS is now 32 again, and
the real registers, that can hold data, are contiguous.

Review-URL: https://codereview.appspot.com/300550043
---------------

Expand All Messages | Collapse All Messages