Issue 4876: Add fontname replacing function for CFF (OTF/OTC) fonts

Issue 4876/5: Add direct parsing CFF for getting Postscript font name

    FreeType 2.6 and 2.6.1 cannot get PS name from pure-CFF.
    (FreeType 2.5.5 and earlier does not have this issue.
     FreeType 2.6.2+ has this bug fixed.)
    So we need direct parsing of the 'CFF' table, in this case.

Issue 4876/4: Enable fontname replacing in TrueType functions

    This commit enables fontname replacing for CFF (OTF/OTC) fonts.

Issue 4876/3: Enable fontname replacing in Pango_font class

    This commit enables fontname replacing for CFF (OTF/OTC) fonts.

Issue 4876/2: Enable fontname replacing in Open_type_font class

    This commit enables fontname replacing for CFF (OTF/OTC) fonts.

Issue 4876/1: Add fontname replacing function for CFF (OTF/OTC) fonts

    For CFF (OTF/OTC) fonts,
    FT_Get_Postscript_Name ()
    in FreeType 2.6+ gets the name in 'name' table.
    However, we want the name in 'CFF' table instead of in 'name' table
    because output postscript file is embedded only 'CFF' table of the font.

    They are inconsistent for some OpenType/CFF Collection fonts (OTC).

    This function can get the name in 'CFF' table.

    TODO: Check conflicts between fonts which have same name in 'CFF' table
    but different name in 'name' table.

[trueroad, 2016-06-25 13:51:19]

Use warning instead of error

[lemzwerg, 2016-06-25 15:34:24]

LGTM, thanks!

https://codereview.appspot.com/300490043/diff/20001/lily/open-type-font.cc
File lily/open-type-font.cc (right):

https://codereview.appspot.com/300490043/diff/20001/lily/open-type-font.cc#ne...
lily/open-type-font.cc:160: string cff_table = get_otf_table (face, "CFF ");
// For OTF and OTC fonts, we use data from the font's 'CFF' table only
// because other tables are not embedded in the output PS file.

[trueroad, 2016-06-25 17:03:25]

Fix comment

[trueroad, 2016-06-25 17:05:18]

Thank you for your reviewing.

https://codereview.appspot.com/300490043/diff/20001/lily/open-type-font.cc
File lily/open-type-font.cc (right):

https://codereview.appspot.com/300490043/diff/20001/lily/open-type-font.cc#ne...
lily/open-type-font.cc:160: string cff_table = get_otf_table (face, "CFF ");
On 2016/06/25 15:34:24, lemzwerg wrote:
> // For OTF and OTC fonts, we use data from the font's 'CFF' table only
> // because other tables are not embedded in the output PS file.

Done.

[trueroad, 2016-06-26 03:59:35]

Add "Issue 4876/5: Add directly parsing CFF for getting Postscript font name"

[lemzwerg, 2016-06-26 04:56:16]

LGTM again, thanks!

https://codereview.appspot.com/300490043/diff/60001/lily/open-type-font.cc
File lily/open-type-font.cc (right):

https://codereview.appspot.com/300490043/diff/60001/lily/open-type-font.cc#ne...
lily/open-type-font.cc:185: //  FreeType 2.6.2+ has been fixed this issue.)
// FreeType 2.6.2+ has this bug fixed.)

https://codereview.appspot.com/300490043/diff/60001/lily/open-type-font.cc#ne...
lily/open-type-font.cc:186: // So we need directly parsing 'CFF' table, in this
case.
// So we need direct parsing of the 'CFF' table, in this case.

https://codereview.appspot.com/300490043/diff/60001/lily/open-type-font.cc#ne...
lily/open-type-font.cc:190: 
// See Adobe technote '5176.CFF.pdf', sections 2 and 5-7.

https://codereview.appspot.com/300490043/diff/60001/lily/open-type-font.cc#ne...
lily/open-type-font.cc:217: + off2 - 1));
This code always gets the first name in the CFF's name index.  Is this
sufficient?

[trueroad, 2016-06-26 07:13:22]

Fix and add comment

[trueroad, 2016-06-26 07:17:08]

Thank you for your comments.

https://codereview.appspot.com/300490043/diff/60001/lily/open-type-font.cc
File lily/open-type-font.cc (right):

https://codereview.appspot.com/300490043/diff/60001/lily/open-type-font.cc#ne...
lily/open-type-font.cc:185: //  FreeType 2.6.2+ has been fixed this issue.)
On 2016/06/26 04:56:16, lemzwerg wrote:
> // FreeType 2.6.2+ has this bug fixed.)

Done.

https://codereview.appspot.com/300490043/diff/60001/lily/open-type-font.cc#ne...
lily/open-type-font.cc:186: // So we need directly parsing 'CFF' table, in this
case.
On 2016/06/26 04:56:16, lemzwerg wrote:
> // So we need direct parsing of the 'CFF' table, in this case.

Done.

https://codereview.appspot.com/300490043/diff/60001/lily/open-type-font.cc#ne...
lily/open-type-font.cc:190: 
On 2016/06/26 04:56:16, lemzwerg wrote:
> // See Adobe technote '5176.CFF.pdf', sections 2 and 5-7.

Done.

https://codereview.appspot.com/300490043/diff/60001/lily/open-type-font.cc#ne...
lily/open-type-font.cc:217: + off2 - 1));
On 2016/06/26 04:56:16, lemzwerg wrote:
> This code always gets the first name in the CFF's name index.  Is this
> sufficient?

I think it is sufficient.

Current LilyPond supports OpenType/CFF fonts (e.g. OTF and OTC).
Other CFF font file is not supported.

OpenType Specification ver. 1.7 says that
"The Name INDEX in the CFF must contain only one entry;"
https://www.microsoft.com/typography/otspec/cff.htm

Therefore, the CFF that is supported by LilyPond has only one name.

In addition, I've never seen the CFF that has multiple names.

[lemzwerg, 2016-06-26 08:05:50]

> > This code always gets the first name in the CFF's name index.  Is this
> > sufficient?
> 
> I think it is sufficient.
> 
> OpenType Specification ver. 1.7 says that
> "The Name INDEX in the CFF must contain only one entry;"
> https://www.microsoft.com/typography/otspec/cff.htm

Ah, yes, I've forgotten this.

[trueroad, 2016-07-04 12:58:00]

I've pushed to staging.

Issue 4876/5: Add direct parsing CFF for getting Postscript font name
commit ca9c7a2c28b32f6abe203979532946d557674891

Issue 4876/4: Enable fontname replacing in TrueType functions
commit 22559b0c3837f49762caa52a7b05f35a156c595f

Issue 4876/3: Enable fontname replacing in Pango_font class
commit de9831ffbac6592724492a21b084726e370bd362

Issue 4876/2: Enable fontname replacing in Open_type_font class
commit 3c2fbb63c2b588dc244197ab7de7f028807833bb

Issue 4876/1: Add fontname replacing function for CFF (OTF/OTC) fonts
commit fa2596b6ec273e7d82907f97acf0c65559b3c1b4