Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(85)

Issue 299460043: Don't treat context modification identifiers special

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by dak
Modified:
7 years, 9 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Don't treat context modification identifiers special This requires using \with before context modifications like \RemoveEmptyStaves in order to make the syntax get along with fewer special cases and exceptions. Also contains commits: Run scripts/auxiliar/update-with-convert-ly.sh convert-ly rule to put \with before context mods \with #*unspecified* should be equivalent to \with { }

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix bad test #

Patch Set 3 : Fix comments in context-mod-with regtest #

Patch Set 4 : Add other context starters to convert-ly rule #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -28 lines) Patch
M input/regression/context-mod-with.ly View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M input/regression/remove-empty-context-mod.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/parser.yy View 1 5 chunks +7 lines, -21 lines 0 comments Download
M python/convertrules.py View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 8
dak
Fix bad test
7 years, 9 months ago (2016-07-01 16:06:31 UTC) #1
thomasmorley651
As always, I can't review parser-code. Though, after discussion here http://lilypond.1069038.n5.nabble.com/tiny-function-td192058.html I vote for it. ...
7 years, 9 months ago (2016-07-02 08:50:10 UTC) #2
dak
https://codereview.appspot.com/299460043/diff/1/input/regression/context-mod-with.ly File input/regression/context-mod-with.ly (right): https://codereview.appspot.com/299460043/diff/1/input/regression/context-mod-with.ly#newcode68 input/regression/context-mod-with.ly:68: % Mods can be inserted instead of a \with ...
7 years, 9 months ago (2016-07-02 09:09:11 UTC) #3
dak
Fix comments in context-mod-with regtest
7 years, 9 months ago (2016-07-02 09:27:13 UTC) #4
Dan Eble
LGTM, though I rarely work with yacc. Requiring \with is a good idea. I don't ...
7 years, 9 months ago (2016-07-02 14:19:31 UTC) #5
dak
On 2016/07/02 14:19:31, Dan Eble wrote: > LGTM, though I rarely work with yacc. Requiring ...
7 years, 9 months ago (2016-07-02 14:52:57 UTC) #6
dak
Add other context starters to convert-ly rule
7 years, 9 months ago (2016-07-02 15:26:30 UTC) #7
Dan Eble
7 years, 9 months ago (2016-07-02 15:26:43 UTC) #8
On 2016/07/02 14:52:57, dak wrote:
> On 2016/07/02 14:19:31, Dan Eble wrote:
> > I don't appreciate the value of \with #*unspecified*. Does it parallel a
> feature
> > that was already used in context mod lists?
> 
> If there is need for discussion, I can move this change into a separate issue.

> It is indeed almost entirely orthogonal to this issue here.

No, there's no problem.  I was using "appreciate" in the sense of understanding
rather than gratitude.  Thanks for the explanation.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b