Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments. Please
Sign in
to add in-line comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(27)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Side by Side Diff: src/test/ns3tcp/response-vectors/ns3tcp-loss-NewReno4-response-vectors.pcap
Issue
299130043
:
TCP SACK + SACK emulation
Patch Set: Fixed NextSeg
Created 7 years, 3 months ago
Left:
Base
Patch Set 1: None
Patch Set 2: Matt comments addressed, ASSERT inserted, management of the RTO improved
Patch Set 3: SACK rebased on top of ns-3-dev
Patch Set 4: Fixed NextSeg
Right:
Patch Set 1: None
Patch Set 2: Matt comments addressed, ASSERT inserted, management of the RTO improved
Patch Set 3: SACK rebased on top of ns-3-dev
Patch Set 4: Fixed NextSeg
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Jump to:
examples/tcp/tcp-variants-comparison.cc
src/internet/doc/tcp.rst
src/internet/model/tcp-option.h
src/internet/model/tcp-option.cc
src/internet/model/tcp-option-sack.h
src/internet/model/tcp-option-sack.cc
src/internet/model/tcp-option-sack-permitted.h
src/internet/model/tcp-option-sack-permitted.cc
src/internet/model/tcp-rx-buffer.h
src/internet/model/tcp-rx-buffer.cc
src/internet/model/tcp-socket-base.h
src/internet/model/tcp-socket-base.cc
src/internet/model/tcp-tx-buffer.h
src/internet/model/tcp-tx-buffer.cc
src/internet/test/tcp-bytes-in-flight-test.cc
src/internet/test/tcp-fast-retr-test.h
src/internet/test/tcp-fast-retr-test.cc
src/internet/test/tcp-general-test.h
src/internet/test/tcp-general-test.cc
src/internet/test/tcp-header-test.cc
src/internet/test/tcp-option-test.cc
src/internet/test/tcp-rto-test.h
src/internet/test/tcp-rto-test.cc
src/internet/test/tcp-rx-buffer-test.cc
src/internet/test/tcp-sack-permitted-test.cc
src/internet/test/tcp-timestamp-test.cc
src/internet/test/tcp-tx-buffer-test.cc
src/internet/wscript
src/test/ns3tcp/ns3tcp-loss-test-suite.cc
src/test/ns3tcp/ns3tcp-state-test-suite.cc
src/test/ns3tcp/response-vectors/ns3tcp-loss-NewReno1-response-vectors.pcap
src/test/ns3tcp/response-vectors/ns3tcp-loss-NewReno2-response-vectors.pcap
src/test/ns3tcp/response-vectors/ns3tcp-loss-NewReno3-response-vectors.pcap
src/test/ns3tcp/response-vectors/ns3tcp-loss-NewReno4-response-vectors.pcap
src/test/ns3tcp/response-vectors/ns3tcp-loss-Westwood2-response-vectors.pcap
src/test/ns3tcp/response-vectors/ns3tcp-loss-Westwood3-response-vectors.pcap
src/test/ns3tcp/response-vectors/ns3tcp-loss-Westwood4-response-vectors.pcap
src/test/ns3tcp/response-vectors/ns3tcp-loss-WestwoodPlus2-response-vectors.pcap
src/test/ns3tcp/response-vectors/ns3tcp-loss-WestwoodPlus3-response-vectors.pcap
src/test/ns3tcp/response-vectors/ns3tcp-loss-WestwoodPlus4-response-vectors.pcap
View unified diff
|
Download patch
« no previous file with comments
|
« src/test/ns3tcp/response-vectors/ns3tcp-loss-NewReno3-response-vectors.pcap
('k') |
src/test/ns3tcp/response-vectors/ns3tcp-loss-Westwood2-response-vectors.pcap »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
OLD
NEW
« no previous file with comments
|
« src/test/ns3tcp/response-vectors/ns3tcp-loss-NewReno3-response-vectors.pcap
('k') |
src/test/ns3tcp/response-vectors/ns3tcp-loss-Westwood2-response-vectors.pcap »
('j') |
no next file with comments »
Issue 299130043: TCP SACK + SACK emulation
Created 7 years, 10 months ago by n.p
Modified 7 years, 3 months ago
Reviewers: mattator
Base URL:
Comments: 17
Recent Issues
|
This issue
This is Rietveld
f62528b