Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4487)

Issue 297960043: Scanner: Fix bug and add coverage for iterators/generators. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 12 months ago by kpreid_google
Modified:
7 years, 12 months ago
Reviewers:
felix8a, MarkM
CC:
google-caja-discuss_googlegroups.com
Visibility:
Public.

Description

* Fix bad function call in Context. This bug was not found before because it only shows up when trying to report an error on this type of scan context. * Coverage/fixes for iterator.next() and *IteratorPrototype. * Coverage/fixes for generators. * Add missing coverage for DOMSettableTokenList. @ a6049ae44f72e5b5de7216bd7c64ec29c5c0e237

Patch Set 1 #

Patch Set 2 : Scanner: Fix bug and add coverage for iterators/generators. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -5 lines) Patch
M tests/com/google/caja/plugin/test-scan-core.js View 2 chunks +4 lines, -3 lines 0 comments Download
M tests/com/google/caja/plugin/test-scan-guest.js View 1 6 chunks +39 lines, -2 lines 0 comments Download

Messages

Total messages: 8
kpreid_google
7 years, 12 months ago (2016-04-28 19:18:16 UTC) #1
felix8a
lgtm. meta-comment: I've already forgotten most of what I know about the scanner, and I'm ...
7 years, 12 months ago (2016-04-28 19:43:52 UTC) #2
kpreid_google
On 2016/04/28 19:43:52, felix8a wrote: > lgtm. > > meta-comment: I've already forgotten most of ...
7 years, 12 months ago (2016-04-28 19:52:00 UTC) #3
kpreid_google
* Fix bad function call in Context. This bug was not found before because it ...
7 years, 12 months ago (2016-04-28 22:01:37 UTC) #4
kpreid_google
New snapshot just moves a function declaration to where it needs to be to obey ...
7 years, 12 months ago (2016-04-28 22:03:24 UTC) #5
MarkM
still LGTM
7 years, 12 months ago (2016-04-28 22:06:17 UTC) #6
MarkM
On 2016/04/28 22:06:17, MarkM wrote: > still LGTM Oops. wrong cl. nevermind
7 years, 12 months ago (2016-04-28 22:06:47 UTC) #7
felix8a
7 years, 12 months ago (2016-04-29 06:00:01 UTC) #8
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b