Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(191)

Issue 297510043: 3 tables etc

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by marcus.falgert
Modified:
6 years, 7 months ago
Reviewers:
marcus.falgert
Visibility:
Public.

Description

Relevant files are: master/upstream_forwarder.py master/upstream_server.py master/downstream_server.py master/downstream_client.py master/tracerouting.py Also, these are relevant but not that important to look at: master/ip_bgp_data.py master/start.py master/topo.py

Patch Set 1 #

Total comments: 73
Unified diffs Side-by-side diffs Delta from patch set Stats (+2187 lines, --29 lines) Patch
A master/.idea/dictionaries/marcus.xml View 1 chunk +8 lines, -0 lines 0 comments Download
A master/.idea/inspectionProfiles/Project_Default.xml View 1 chunk +27 lines, -0 lines 0 comments Download
A master/.idea/inspectionProfiles/profiles_settings.xml View 1 chunk +7 lines, -0 lines 0 comments Download
A master/.idea/master.iml View 1 chunk +11 lines, -0 lines 0 comments Download
A master/.idea/misc.xml View 1 chunk +14 lines, -0 lines 0 comments Download
A master/.idea/modules.xml View 1 chunk +8 lines, -0 lines 0 comments Download
A master/.idea/workspace.xml View 1 chunk +582 lines, -0 lines 0 comments Download
A + master/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A master/backup_stuff View 1 chunk +2 lines, -0 lines 0 comments Download
A master/boot.sh View 1 chunk +9 lines, -0 lines 0 comments Download
A master/conf_saved.data View 1 chunk +219 lines, -0 lines 0 comments Download
A master/configs/IMPORTANT-COMMANDS View 1 chunk +13 lines, -0 lines 0 comments Download
A master/configs/a_h1/bgpd.conf View 1 chunk +43 lines, -0 lines 0 comments Download
A + master/configs/a_h1/daemons View 0 chunks +-1 lines, --1 lines 0 comments Download
A + master/configs/a_h1/debian.conf View 0 chunks +-1 lines, --1 lines 0 comments Download
A master/configs/a_h1/zebra.conf View 1 chunk +12 lines, -0 lines 0 comments Download
A master/configs/a_r1/bgpd.conf View 1 chunk +52 lines, -0 lines 0 comments Download
A + master/configs/a_r1/daemons View 0 chunks +-1 lines, --1 lines 0 comments Download
A + master/configs/a_r1/debian.conf View 0 chunks +-1 lines, --1 lines 0 comments Download
A master/configs/a_r1/zebra.conf View 1 chunk +12 lines, -0 lines 0 comments Download
A master/configs/b_r1/bgpd.conf View 1 chunk +31 lines, -0 lines 0 comments Download
A + master/configs/b_r1/daemons View 0 chunks +-1 lines, --1 lines 0 comments Download
A + master/configs/b_r1/debian.conf View 0 chunks +-1 lines, --1 lines 0 comments Download
A master/configs/b_r1/zebra.conf View 1 chunk +12 lines, -0 lines 0 comments Download
A master/configs/c_r1/bgpd.conf View 1 chunk +29 lines, -0 lines 0 comments Download
A + master/configs/c_r1/daemons View 0 chunks +-1 lines, --1 lines 0 comments Download
A + master/configs/c_r1/debian.conf View 0 chunks +-1 lines, --1 lines 0 comments Download
A master/configs/c_r1/zebra.conf View 1 chunk +11 lines, -0 lines 0 comments Download
A master/configs/d_r1/bgpd.conf View 1 chunk +29 lines, -0 lines 0 comments Download
A + master/configs/d_r1/daemons View 0 chunks +-1 lines, --1 lines 0 comments Download
A + master/configs/d_r1/debian.conf View 0 chunks +-1 lines, --1 lines 0 comments Download
A master/configs/d_r1/zebra.conf View 1 chunk +11 lines, -0 lines 0 comments Download
A master/configs/e_r1/bgpd.conf View 1 chunk +29 lines, -0 lines 0 comments Download
A + master/configs/e_r1/daemons View 0 chunks +-1 lines, --1 lines 0 comments Download
A + master/configs/e_r1/debian.conf View 0 chunks +-1 lines, --1 lines 0 comments Download
A master/configs/e_r1/zebra.conf View 1 chunk +11 lines, -0 lines 0 comments Download
A master/configs/f_r1/bgpd.conf View 1 chunk +31 lines, -0 lines 0 comments Download
A + master/configs/f_r1/daemons View 0 chunks +-1 lines, --1 lines 0 comments Download
A + master/configs/f_r1/debian.conf View 0 chunks +-1 lines, --1 lines 0 comments Download
A master/configs/f_r1/zebra.conf View 1 chunk +12 lines, -0 lines 0 comments Download
A master/configs/g_r1/bgpd.conf View 1 chunk +30 lines, -0 lines 0 comments Download
A + master/configs/g_r1/daemons View 0 chunks +-1 lines, --1 lines 0 comments Download
A + master/configs/g_r1/debian.conf View 0 chunks +-1 lines, --1 lines 0 comments Download
A master/configs/g_r1/zebra.conf View 1 chunk +11 lines, -0 lines 0 comments Download
A master/configs/h_r1/bgpd.conf View 1 chunk +33 lines, -0 lines 0 comments Download
A + master/configs/h_r1/daemons View 0 chunks +-1 lines, --1 lines 0 comments Download
A + master/configs/h_r1/debian.conf View 0 chunks +-1 lines, --1 lines 0 comments Download
A master/configs/h_r1/zebra.conf View 1 chunk +11 lines, -0 lines 0 comments Download
A master/configs/i_r1/bgpd.conf View 1 chunk +31 lines, -0 lines 0 comments Download
A + master/configs/i_r1/daemons View 0 chunks +-1 lines, --1 lines 0 comments Download
A + master/configs/i_r1/debian.conf View 0 chunks +-1 lines, --1 lines 0 comments Download
A master/configs/i_r1/zebra.conf View 1 chunk +12 lines, -0 lines 0 comments Download
A master/configs/j_r1/bgpd.conf View 1 chunk +29 lines, -0 lines 0 comments Download
A + master/configs/j_r1/daemons View 0 chunks +-1 lines, --1 lines 0 comments Download
A + master/configs/j_r1/debian.conf View 0 chunks +-1 lines, --1 lines 0 comments Download
A master/configs/j_r1/zebra.conf View 1 chunk +11 lines, -0 lines 0 comments Download
A master/configs/k_r1/bgpd.conf View 1 chunk +29 lines, -0 lines 0 comments Download
A + master/configs/k_r1/daemons View 0 chunks +-1 lines, --1 lines 0 comments Download
A + master/configs/k_r1/debian.conf View 0 chunks +-1 lines, --1 lines 0 comments Download
A master/configs/k_r1/zebra.conf View 1 chunk +11 lines, -0 lines 0 comments Download
A master/configs/l_r1/bgpd.conf View 1 chunk +29 lines, -0 lines 0 comments Download
A + master/configs/l_r1/daemons View 0 chunks +-1 lines, --1 lines 0 comments Download
A + master/configs/l_r1/debian.conf View 0 chunks +-1 lines, --1 lines 0 comments Download
A master/configs/l_r1/zebra.conf View 1 chunk +11 lines, -0 lines 0 comments Download
A master/configs/z_r1/bgpd.conf View 1 chunk +29 lines, -0 lines 0 comments Download
A + master/configs/z_r1/daemons View 0 chunks +-1 lines, --1 lines 0 comments Download
A + master/configs/z_r1/debian.conf View 0 chunks +-1 lines, --1 lines 0 comments Download
A master/configs/z_r1/zebra.conf View 1 chunk +11 lines, -0 lines 0 comments Download
A master/downstream_client.py View 1 chunk +56 lines, -0 lines 8 comments Download
A master/downstream_server.py View 1 chunk +177 lines, -0 lines 29 comments Download
A master/ip_bgp_data.py View 1 chunk +53 lines, -0 lines 6 comments Download
A master/scripts/clear_out.sh View 1 chunk +3 lines, -0 lines 0 comments Download
A master/scripts/prepend.sh View 1 chunk +7 lines, -0 lines 0 comments Download
A master/scripts/prepend_2.sh View 1 chunk +7 lines, -0 lines 0 comments Download
A master/scripts/results View 1 chunk +5 lines, -0 lines 0 comments Download
A master/scripts/show_bgp_log.sh View 1 chunk +3 lines, -0 lines 0 comments Download
A master/scripts/show_config.sh View 1 chunk +3 lines, -0 lines 0 comments Download
A master/scripts/show_zebra_log.sh View 1 chunk +3 lines, -0 lines 0 comments Download
A master/scripts/test.sh View 1 chunk +9 lines, -0 lines 0 comments Download
A master/start.py View 1 chunk +108 lines, -0 lines 0 comments Download
A master/topo.py View 1 chunk +113 lines, -0 lines 0 comments Download
A master/topology.png View Binary file 0 comments Download
A master/tracerouting.py View 1 chunk +65 lines, -0 lines 8 comments Download
A master/upstream_forwarder.py View 1 chunk +41 lines, -0 lines 10 comments Download
A master/upstream_server.py View 1 chunk +50 lines, -0 lines 12 comments Download

Messages

Total messages: 4
marcus.falgert
See description :)
7 years, 9 months ago (2016-06-08 12:07:46 UTC) #1
kirill.sc
https://codereview.appspot.com/297510043/diff/1/master/downstream_client.py File master/downstream_client.py (right): https://codereview.appspot.com/297510043/diff/1/master/downstream_client.py#newcode15 master/downstream_client.py:15: response, addr = client_socket.recvfrom(1024) hardcoded 1024, is it a ...
7 years, 9 months ago (2016-06-09 07:35:50 UTC) #2
marcus.falgert
Thanks for the review, much appreciated :) https://codereview.appspot.com/297510043/diff/1/master/downstream_client.py File master/downstream_client.py (right): https://codereview.appspot.com/297510043/diff/1/master/downstream_client.py#newcode15 master/downstream_client.py:15: response, addr ...
7 years, 9 months ago (2016-06-09 08:33:21 UTC) #3
kirill.sc
6 years, 7 months ago (2017-08-17 07:10:06 UTC) #4

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b