Issue 296650043: i#1569 AArch64: Make ELF_R_TLS_DESC fail at run time, not load time.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 296650043: i#1569 AArch64: Make ELF_R_TLS_DESC fail at run time, not load time. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 9 months ago by Edmund.Grimley.Evans

Modified:
7 years, 9 months ago

Reviewers:
bruening

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- i#1569 AArch64: Make ELF_R_TLS_DESC fail at run time, not load time. A TLS descriptor contains a pointer to a function that is invoked lazily to resolve the relocation. Rather than fail when loading a shared object it is more helpful to fail only if there is an attempt to resolve the relocation at run time. Sometimes there is no such attempt. ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	core/unix/module_elf.c	View		2 chunks	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Edmund.Grimley.Evans

Committed as https://github.com/DynamoRIO/dynamorio/commit/b86fc3a3ab2dd26d64b938530cb01a713e460359 Final commit log: --------------- i#1569 AArch64: Make ELF_R_TLS_DESC fail at run time, ...

7 years, 9 months ago (2016-07-04 08:38:32 UTC) #3

bruening

You're in the process of fixing the build breakage from this?

7 years, 9 months ago (2016-07-04 15:43:51 UTC) #4

Edmund.Grimley.Evans

On 2016/07/04 15:43:51, bruening wrote: > You're in the process of fixing the build breakage ...

7 years, 9 months ago (2016-07-04 15:53:21 UTC) #5

Edmund.Grimley.Evans

7 years, 9 months ago (2016-07-04 16:06:54 UTC) #6

Message was sent while issue was closed.

On 2016/07/04 15:53:21, Edmund.Grimley.Evans wrote:
> On 2016/07/04 15:43:51, bruening wrote:
> > You're in the process of fixing the build breakage from this?
> 
> I'd not noticed till you pointed it out! But I'm looking at it now...

Presumably the solution is to put "#ifndef ANDROID" round the definition of
tlsdesc_resolver ... or get rid of the highly annoying
"-Werror=unused-function".

Expand All Messages | Collapse All Messages