Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(877)

Issue 296520043: Add Message track

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by michelzel
Modified:
7 years, 8 months ago
CC:
gsutil-crs_google.com
Visibility:
Public.

Description

Add Message track

Patch Set 1 #

Total comments: 51

Patch Set 2 : CR feedback round 1 thobrla #

Total comments: 20

Patch Set 3 : CR feedback round 2 thobrla #

Total comments: 28

Patch Set 4 : CR feedback round 3 thobrla #

Total comments: 12

Patch Set 5 : CR feedback round 4 thobrla #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -36 lines) Patch
M gslib/command.py View 1 6 chunks +9 lines, -6 lines 0 comments Download
M gslib/commands/hash.py View 1 chunk +3 lines, -1 line 0 comments Download
M gslib/commands/rewrite.py View 2 chunks +6 lines, -5 lines 0 comments Download
M gslib/copy_helper.py View 1 2 3 4 35 chunks +157 lines, -21 lines 0 comments Download
M gslib/progress_callback.py View 1 2 3 5 chunks +30 lines, -3 lines 0 comments Download
M gslib/seek_ahead_thread.py View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
A gslib/thread_message.py View 1 2 3 4 1 chunk +138 lines, -0 lines 0 comments Download

Messages

Total messages: 14
michelzel
Planned final commit message: Add Message track
7 years, 9 months ago (2016-06-21 22:44:30 UTC) #1
thobrla
https://codereview.appspot.com/296520043/diff/1/gslib/copy_helper.py File gslib/copy_helper.py (right): https://codereview.appspot.com/296520043/diff/1/gslib/copy_helper.py#newcode944 gslib/copy_helper.py:944: def _GetComponentNumber(component): This is only for uploads, right, and ...
7 years, 9 months ago (2016-06-22 01:05:36 UTC) #2
michelzel
https://codereview.appspot.com/296520043/diff/1/gslib/copy_helper.py File gslib/copy_helper.py (right): https://codereview.appspot.com/296520043/diff/1/gslib/copy_helper.py#newcode944 gslib/copy_helper.py:944: def _GetComponentNumber(component): On 2016/06/22 01:05:34, thobrla wrote: > This ...
7 years, 9 months ago (2016-06-23 00:16:22 UTC) #3
thobrla
https://codereview.appspot.com/296520043/diff/1/gslib/copy_helper.py File gslib/copy_helper.py (right): https://codereview.appspot.com/296520043/diff/1/gslib/copy_helper.py#newcode2170 gslib/copy_helper.py:2170: size = component.end_byte-component.start_byte On 2016/06/23 00:16:20, michelzel wrote: > ...
7 years, 9 months ago (2016-06-23 01:45:10 UTC) #4
michelzel
It took longer than I thought it would, I apologize for that! https://codereview.appspot.com/296520043/diff/20001/gslib/copy_helper.py File gslib/copy_helper.py ...
7 years, 9 months ago (2016-06-23 22:07:43 UTC) #5
thobrla
https://codereview.appspot.com/296520043/diff/40001/gslib/copy_helper.py File gslib/copy_helper.py (right): https://codereview.appspot.com/296520043/diff/40001/gslib/copy_helper.py#newcode1427 gslib/copy_helper.py:1427: try: Here and below, this isn't an exceptional case, ...
7 years, 9 months ago (2016-06-24 00:09:04 UTC) #6
michelzel
Since I had a couple of questions, I will wait to hear what should be ...
7 years, 9 months ago (2016-06-24 08:29:14 UTC) #7
thobrla
I don't actually see a patch for the most recent round of comments. https://codereview.appspot.com/296520043/diff/40001/gslib/copy_helper.py File ...
7 years, 9 months ago (2016-06-24 16:14:38 UTC) #8
michelzel
https://codereview.appspot.com/296520043/diff/40001/gslib/copy_helper.py File gslib/copy_helper.py (right): https://codereview.appspot.com/296520043/diff/40001/gslib/copy_helper.py#newcode1427 gslib/copy_helper.py:1427: try: On 2016/06/24 16:14:38, thobrla wrote: > On 2016/06/24 ...
7 years, 9 months ago (2016-06-24 21:07:26 UTC) #9
thobrla
https://codereview.appspot.com/296520043/diff/60001/gslib/copy_helper.py File gslib/copy_helper.py (right): https://codereview.appspot.com/296520043/diff/60001/gslib/copy_helper.py#newcode1501 gslib/copy_helper.py:1501: if is_component: Nit: Here and below, you could avoid ...
7 years, 9 months ago (2016-06-24 21:31:01 UTC) #10
michelzel
https://codereview.appspot.com/296520043/diff/60001/gslib/copy_helper.py File gslib/copy_helper.py (right): https://codereview.appspot.com/296520043/diff/60001/gslib/copy_helper.py#newcode1501 gslib/copy_helper.py:1501: if is_component: On 2016/06/24 21:31:00, thobrla wrote: > Nit: ...
7 years, 9 months ago (2016-06-24 22:53:18 UTC) #11
thobrla
LGTM Please get review from yarbrough@ also. As discussed, once you have LGTMs from both ...
7 years, 9 months ago (2016-06-24 23:44:16 UTC) #12
michelzel
Ok, cool! On Fri, Jun 24, 2016 at 4:44 PM, <thobrla@google.com> wrote: > LGTM > ...
7 years, 9 months ago (2016-06-24 23:45:09 UTC) #13
thobrla
7 years, 9 months ago (2016-06-29 20:10:43 UTC) #14
+Jessica for access
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b