Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(100)

Issue 296010043: Avoid some C++ comparisons of SCM values (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by pkx166h
Modified:
7 years, 10 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Avoid some C++ comparisons of SCM values

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M lily/axis-group-interface.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/output-def-scheme.cc View 2 chunks +2 lines, -2 lines 1 comment Download
M lily/scheme-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
pkx166h
I get a seg fault after applying the patch and doing make Processing `/home/james/lilypond-git/ly/generate-documentation.ly' Parsing... ...
7 years, 11 months ago (2016-04-21 18:08:03 UTC) #1
dak
7 years, 10 months ago (2016-05-04 21:29:07 UTC) #2
https://codereview.appspot.com/296010043/diff/1/lily/output-def-scheme.cc
File lily/output-def-scheme.cc (right):

https://codereview.appspot.com/296010043/diff/1/lily/output-def-scheme.cc#new...
lily/output-def-scheme.cc:104: if (td && scm_is_eq (key, td->get_context_name
()));
Man, is this the obfuscated C context or what?  The semicolon at the end of the
if-condition is the deadly sin.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b