Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(150)

Issue 295480044: Remove ack_finder/ack_find_base (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 7 months ago by dak
Modified:
1 month ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Remove ack_finder/ack_find_base ADD_ACKNOWLEDGER and ADD_END_ACKNOWLEDGER can work without them when the base is specified correctly when calling them inside of some CLASS::boot (). Also contains commits: Let ADD_ACKNOWLEDGER state actual classes Declaring the correct containing classes for acknowledgers allows dropping a bunch of black magic. Simplify ADD_{,END_}ACKNOWLEDGER No explicit scopes are needed any more since they are run from within the static member function CLASS::boot () .

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -50 lines) Patch
M lily/auto-beam-engraver.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M lily/beam-engraver.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/include/engraver.hh View 1 chunk +0 lines, -3 lines 0 comments Download
M lily/include/translator.hh View 2 chunks +1 line, -13 lines 0 comments Download
M lily/include/translator.icc View 1 chunk +6 lines, -5 lines 0 comments Download
M lily/kievan-ligature-engraver.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/mensural-ligature-engraver.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/phrasing-slur-engraver.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M lily/slur-engraver.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M lily/vaticana-ligature-engraver.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b