Issue 295430043: Remove Protected_scm destructor

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 295430043: Remove Protected_scm destructor (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 10 months ago by dak

Modified:
2 years, 4 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Remove Protected_scm destructor Protected_scm works only for static data and single members cannot be destructed without destroying the whole protection chain. When static member destructors are called, the Guile memory subsystem is already down, so tampering with the storage is just a waste of effort and snake oil at best.

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -10 lines)			Patch
	M	lily/include/protected-scm.hh	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	lily/protected-scm.cc	View		1 chunk	+0 lines, -9 lines	0 comments	Download