Issue 294430043: Make SES makeArrayLike tolerate Symbols.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 294430043: Make SES makeArrayLike tolerate Symbols. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 11 months ago by kpreid_google

Modified:
7 years, 11 months ago

Reviewers:
MarkM

CC:
google-caja-discuss_googlegroups.com

Visibility:
Public.

More Reviews

Description

This is needed because Firefox currently has both Symbols and Proxy.create, and ('' + P) throws when P is a Symbol. @ 1d8af47ead4a805b7805ffe8bd1eb4a0c9fad5f8

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -13 lines)			Patch
	M	src/com/google/caja/ses/startSES.js	View		6 chunks	+26 lines, -13 lines	0 comments	Download
	M	tests/com/google/caja/plugin/test-language-guest.html	View		1 chunk	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

MarkM

7 years, 11 months ago (2016-04-28 21:56:12 UTC) #2

LGTM

(Note that my understanding of the scanning/testing framework is shallow.)

Expand All Messages | Collapse All Messages