Issue 294260043: [plaso] Moved FakeFileSystemBuilder to dfvfs.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 294260043: [plaso] Moved FakeFileSystemBuilder to dfvfs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years ago by Joachim Metz

Modified:
7 years, 11 months ago

Reviewers:
onager

CC:
kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

[plaso] Moved FakeFileSystemBuilder to dfvfs. Requires: * updated dfvfs in l2tbinaries win32 for AppVeyor

Patch Set 2 : Changes to fix tests. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -157 lines)			Patch
M	plaso/dependencies.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/engine/engine.py	View		3 chunks	+23 lines, -6 lines	0 comments	Download
M	tests/preprocessors/linux.py	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/preprocessors/macosx.py	View		6 chunks	+12 lines, -11 lines	0 comments	Download
M	tests/preprocessors/test_lib.py	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	tests/preprocessors/windows.py	View		6 chunks	+11 lines, -9 lines	0 comments	Download
M	tests/test_lib.py	View		1 chunk	+0 lines, -126 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

onager

LGTM https://codereview.appspot.com/294260043/diff/1/tests/preprocessors/test_lib.py File tests/preprocessors/test_lib.py (right): https://codereview.appspot.com/294260043/diff/1/tests/preprocessors/test_lib.py#newcode17 tests/preprocessors/test_lib.py:17: def _GetTestFilePath(self, path_segments): Perhaps we should have an ...

7 years, 11 months ago (2016-04-28 11:26:35 UTC) #2

Joachim Metz

https://codereview.appspot.com/294260043/diff/1/tests/preprocessors/test_lib.py File tests/preprocessors/test_lib.py (right): https://codereview.appspot.com/294260043/diff/1/tests/preprocessors/test_lib.py#newcode17 tests/preprocessors/test_lib.py:17: def _GetTestFilePath(self, path_segments): Ack added reminder to: https://github.com/log2timeline/plaso/issues/160

7 years, 11 months ago (2016-04-28 19:06:22 UTC) #3

Joachim Metz

7 years, 11 months ago (2016-05-11 04:41:55 UTC) #5

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close fakefsbuilder

Expand All Messages | Collapse All Messages