Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1515)

Issue 293130043: ICU ticket #11852: change ICU CollationKey to extend java.text.CollationKey (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by markus.icu
Modified:
7 years, 2 months ago
Reviewers:
yoshito_umaoka
CC:
mark_macchiato.com
Base URL:
http://source.icu-project.org/repos/icu/icu4j/trunk
Visibility:
Public.

Description

ICU ticket #11852: change ICU CollationKey to extend java.text.CollationKey

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -48 lines) Patch
M main/classes/collate/src/com/ibm/icu/text/CollationKey.java View 17 chunks +60 lines, -48 lines 1 comment Download

Messages

Total messages: 4
markus.icu
7 years, 11 months ago (2016-04-12 00:12:22 UTC) #1
markus.icu
https://codereview.appspot.com/293130043/diff/1/main/classes/collate/src/com/ibm/icu/text/CollationKey.java File main/classes/collate/src/com/ibm/icu/text/CollationKey.java (right): https://codereview.appspot.com/293130043/diff/1/main/classes/collate/src/com/ibm/icu/text/CollationKey.java#newcode85 main/classes/collate/src/com/ibm/icu/text/CollationKey.java:85: public final class CollationKey extends java.text.CollationKey { Note: The ...
7 years, 11 months ago (2016-04-12 00:15:02 UTC) #2
mark_macchiato.com
​The idea sounds good. Java's CollationKey isn't serializable (thank the gods), and I don't see ...
7 years, 11 months ago (2016-04-12 07:24:48 UTC) #3
markus.icu
7 years, 2 months ago (2017-01-13 01:10:11 UTC) #4
withdrawn
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b