Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(247)

Issue 292560043: Support symbols in ES5/3 ArrayLike. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by kpreid_google
Modified:
7 years, 11 months ago
Reviewers:
MarkM
CC:
google-caja-discuss_googlegroups.com
Visibility:
Public.

Description

This is almost identical to the corresponding change in SES makeArrayLike, commit 1d8af47ead4a805b7805ffe8bd1eb4a0c9fad5f8; the difference is that the existing isNumericName function is modified. (The existing behavior is unchanged when the precondition is respected.) @ 2828c024e331140cc17facf79b6e300caf9c1b30

Patch Set 1 #

Total comments: 2

Patch Set 2 : Support symbols in ES5/3 ArrayLike. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M src/com/google/caja/es53.js View 1 6 chunks +17 lines, -8 lines 0 comments Download

Messages

Total messages: 5
kpreid_google
7 years, 11 months ago (2016-04-28 23:08:40 UTC) #1
MarkM
https://codereview.appspot.com/292560043/diff/1/src/com/google/caja/es53.js File src/com/google/caja/es53.js (right): https://codereview.appspot.com/292560043/diff/1/src/com/google/caja/es53.js#newcode1041 src/com/google/caja/es53.js:1041: return type === 'number' || (type !== 'symbol' && ...
7 years, 11 months ago (2016-04-28 23:12:17 UTC) #2
kpreid_google
This is almost identical to the corresponding change in SES makeArrayLike, commit 1d8af47ead4a805b7805ffe8bd1eb4a0c9fad5f8; the difference ...
7 years, 11 months ago (2016-04-28 23:26:52 UTC) #3
kpreid_google
https://codereview.appspot.com/292560043/diff/1/src/com/google/caja/es53.js File src/com/google/caja/es53.js (right): https://codereview.appspot.com/292560043/diff/1/src/com/google/caja/es53.js#newcode1041 src/com/google/caja/es53.js:1041: return type === 'number' || (type !== 'symbol' && ...
7 years, 11 months ago (2016-04-28 23:27:31 UTC) #4
MarkM
7 years, 11 months ago (2016-04-28 23:28:50 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b