Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1223)

Issue 292110043: Keep "\""-signs for graphviz (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by thomasmorley651
Modified:
7 years ago
Reviewers:
pkx166h
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Keep "\""-signs for graphviz Transform them to "\\\""

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M ly/graphviz-init.ly View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 2
thomasmorley651
Please review Not sure, whether it's the best way to do it.
8 years ago (2016-03-22 11:09:38 UTC) #1
pkx166h
8 years ago (2016-03-26 10:15:13 UTC) #2
I cannot test this patch using the method suggested by Thomas from the CG:

http://www.lilypond.org/doc/v2.19/Documentation/contributor/tracing-object-re...

as it appears to no longer work (or we need more 'steps' or information for
those that don't know enough about how graphviz and LP are supposed to work
together).

So the least I can do is to test this the 'usual' way.

Passes make, make check and a full make doc.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b