Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5036)

Issue 29120043: Fix bad call to bundle import helpers.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by rharding
Modified:
10 years, 5 months ago
Reviewers:
mp+195826, jeff.pihach
Visibility:
Public.

Description

Fix bad call to bundle import helpers. - Fixes call to drag and drop of deployer files - Adds missing test for the if branch that called the bundle import helper function. https://code.launchpad.net/~rharding/juju-gui/fix-file-dnd/+merge/195826 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix bad call to bundle import helpers. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -4 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/assets/javascripts/bundle-import-helpers.js View 2 chunks +2 lines, -2 lines 0 comments Download
M app/views/topology/service.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_bundle_import_helpers.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_service_module.js View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 5
rharding
Please take a look.
10 years, 5 months ago (2013-11-19 17:04:06 UTC) #1
rharding
Reviewer comments added. https://codereview.appspot.com/29120043/diff/1/app/assets/javascripts/bundle-import-helpers.js File app/assets/javascripts/bundle-import-helpers.js (right): https://codereview.appspot.com/29120043/diff/1/app/assets/javascripts/bundle-import-helpers.js#newcode216 app/assets/javascripts/bundle-import-helpers.js:216: title: 'Updated status for deployment id: ...
10 years, 5 months ago (2013-11-19 17:05:46 UTC) #2
jeff.pihach
Code LGTM QA NOT OK When dragging and dropping a bundle yaml file I get ...
10 years, 5 months ago (2013-11-19 17:11:09 UTC) #3
jeff.pihach
QA OK on real environment. Previous QA failure is being fixed in another branch.
10 years, 5 months ago (2013-11-19 17:41:25 UTC) #4
rharding
10 years, 5 months ago (2013-11-19 17:49:58 UTC) #5
*** Submitted:

Fix bad call to bundle import helpers.

- Fixes call to drag and drop of deployer files
- Adds missing test for the if branch that called the bundle import helper
function.

R=jeff.pihach
CC=
https://codereview.appspot.com/29120043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b