Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(488)

Issue 290970043: Bug 1252849 - Remove export-grade cipher suites

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 7 months ago by ttaubert
Modified:
5 years, 7 months ago
Reviewers:
ekr, mt, ekr-rietveld
Visibility:
Public.

Description

Bug 1252849 - Remove export-grade cipher suites

Patch Set 1 #

Total comments: 20

Patch Set 2 : Bug 1252849 - Remove export-grade cipher suites #

Patch Set 3 : Added tests #

Total comments: 1

Patch Set 4 : Initialize keyData[] and random[] to zero #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -1068 lines) Patch
M cmd/listsuites/listsuites.c View 1 chunk +1 line, -2 lines 0 comments Download
M cmd/selfserv/selfserv.c View 11 chunks +5 lines, -78 lines 0 comments Download
M cmd/strsclnt/strsclnt.c View 1 chunk +4 lines, -4 lines 0 comments Download
M cmd/tstclnt/tstclnt.c View 1 2 7 chunks +5 lines, -19 lines 0 comments Download
M cmd/vfyserv/vfyutil.c View 1 chunk +4 lines, -4 lines 0 comments Download
M external_tests/pk11_gtest/manifest.mn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A external_tests/pk11_gtest/pk11_export_unittest.cc View 1 2 3 1 chunk +73 lines, -0 lines 0 comments Download
M lib/softoken/pkcs11c.c View 1 3 chunks +43 lines, -172 lines 0 comments Download
M lib/ssl/derive.c View 7 chunks +4 lines, -152 lines 0 comments Download
M lib/ssl/dtlscon.c View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M lib/ssl/ssl.h View 1 chunk +1 line, -4 lines 0 comments Download
M lib/ssl/ssl3con.c View 1 2 23 chunks +30 lines, -414 lines 0 comments Download
M lib/ssl/ssl3prot.h View 1 chunk +0 lines, -7 lines 0 comments Download
M lib/ssl/sslenum.c View 1 chunk +0 lines, -8 lines 0 comments Download
M lib/ssl/sslerr.h View 1 chunk +1 line, -0 lines 0 comments Download
M lib/ssl/sslimpl.h View 1 2 9 chunks +6 lines, -26 lines 0 comments Download
M lib/ssl/sslinfo.c View 2 chunks +0 lines, -55 lines 0 comments Download
M lib/ssl/sslproto.h View 4 chunks +22 lines, -23 lines 0 comments Download
M lib/ssl/sslsecur.c View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M lib/ssl/sslsock.c View 1 2 11 chunks +1 line, -39 lines 0 comments Download
M lib/ssl/sslt.h View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/util/pkcs11t.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/iopr/server_scr/cipher.list View 3 chunks +1 line, -26 lines 0 comments Download
M tests/ssl/ssl.sh View 2 chunks +2 lines, -7 lines 0 comments Download
M tests/ssl/sslcov.txt View 4 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 7
mt
This is pretty good. A few lapses with public header files, but other than that ...
5 years, 7 months ago (2016-03-02 19:37:30 UTC) #1
ttaubert
https://codereview.appspot.com/290970043/diff/1/lib/softoken/pkcs11c.c File lib/softoken/pkcs11c.c (left): https://codereview.appspot.com/290970043/diff/1/lib/softoken/pkcs11c.c#oldcode6471 lib/softoken/pkcs11c.c:6471: ((!ssl3_keys->bIsExport) * IVSize)); On 2016/03/02 19:37:31, mt wrote: > ...
5 years, 7 months ago (2016-03-03 10:56:49 UTC) #2
mt
https://codereview.appspot.com/290970043/diff/1/lib/softoken/pkcs11c.c File lib/softoken/pkcs11c.c (left): https://codereview.appspot.com/290970043/diff/1/lib/softoken/pkcs11c.c#oldcode6471 lib/softoken/pkcs11c.c:6471: ((!ssl3_keys->bIsExport) * IVSize)); On 2016/03/03 10:56:48, ttaubert wrote: > ...
5 years, 7 months ago (2016-03-03 21:28:38 UTC) #3
ttaubert
https://codereview.appspot.com/290970043/diff/1/lib/softoken/pkcs11c.c File lib/softoken/pkcs11c.c (left): https://codereview.appspot.com/290970043/diff/1/lib/softoken/pkcs11c.c#oldcode6471 lib/softoken/pkcs11c.c:6471: ((!ssl3_keys->bIsExport) * IVSize)); On 2016/03/03 21:28:37, mt wrote: > ...
5 years, 7 months ago (2016-03-09 13:41:23 UTC) #4
mt
https://codereview.appspot.com/290970043/diff/40001/external_tests/pk11_gtest/pk11_export_unittest.cc File external_tests/pk11_gtest/pk11_export_unittest.cc (right): https://codereview.appspot.com/290970043/diff/40001/external_tests/pk11_gtest/pk11_export_unittest.cc#newcode29 external_tests/pk11_gtest/pk11_export_unittest.cc:29: &keyItem, nullptr)); Am I reading this correctly? Is this ...
5 years, 7 months ago (2016-03-09 17:35:36 UTC) #5
ttaubert
On 2016/03/09 17:35:36, mt wrote: > https://codereview.appspot.com/290970043/diff/40001/external_tests/pk11_gtest/pk11_export_unittest.cc > File external_tests/pk11_gtest/pk11_export_unittest.cc (right): > > https://codereview.appspot.com/290970043/diff/40001/external_tests/pk11_gtest/pk11_export_unittest.cc#newcode29 > ...
5 years, 7 months ago (2016-03-09 19:35:14 UTC) #6
mt
5 years, 7 months ago (2016-03-09 19:42:18 UTC) #7
On 2016/03/09 19:35:14, ttaubert wrote:
> If you don't like this I could also initialize to zero.

Initialize to something, anything.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b