Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(737)

Issue 2907: Test Issue: Changing Group's base class to SkinnableComponent

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by frishy
Modified:
2 months ago
Reviewers:
egeorgie, hmuller, evtim, rfrishbe
Base URL:
http://opensource.adobe.com/svn/opensource/flex/sdk/trunk/
Visibility:
Public.

Description

This one should work, unlike the last one.

Patch Set 1 #

Patch Set 2 : updating patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
frameworks/projects/flex4/src/flex/component/ItemRenderer.as View 1 chunk +1 line, -1 line 0 comments Download
frameworks/projects/flex4/src/flex/component/Panel.as View 1 chunk +2 lines, -1 line 0 comments Download
frameworks/projects/flex4/src/flex/core/Group.as View 1 chunk +1 line, -1 line 0 comments Download
frameworks/projects/flex4/src/flex/core/MXMLComponent.as View 1 1 chunk +6 lines, -6 lines 1 comment Download
frameworks/projects/flex4/src/flex/core/SkinnableComponent.as View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 6
frishy
10 years, 4 months ago (2008-08-13 00:08:56 UTC) #1
frishy
http://codereview.appspot.com/2907/diff/1/5 File frameworks/projects/flex4/src/flex/core/MXMLComponent.as (left): http://codereview.appspot.com/2907/diff/1/5#oldcode51 Line 51: return _selected; What are you doing here?
10 years, 4 months ago (2008-08-13 00:11:00 UTC) #2
frishy
http://codereview.appspot.com/2907/diff/1/5 File frameworks/projects/flex4/src/flex/core/MXMLComponent.as (left): http://codereview.appspot.com/2907/diff/1/5#oldcode54 Line 54: public function set selected(value:Boolean):void Test comment #2
10 years, 4 months ago (2008-08-13 00:18:25 UTC) #3
frishy
http://codereview.appspot.com/2907/diff/1/3 File frameworks/projects/flex4/src/flex/component/Panel.as (right): http://codereview.appspot.com/2907/diff/1/3#newcode19 Line 19: public class Panel extends Group really?
10 years, 4 months ago (2008-08-13 00:19:35 UTC) #4
frishy
updating patch
10 years, 4 months ago (2008-08-13 00:21:29 UTC) #5
evtim
10 years, 4 months ago (2008-08-13 17:23:49 UTC) #6
Looks good :)

http://codereview.appspot.com/2907/diff/28/11
File frameworks/projects/flex4/src/flex/core/MXMLComponent.as (right):

http://codereview.appspot.com/2907/diff/28/11#newcode51
Line 51: return _selected2;
Why do we rename this? (test comment)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b