Issue 2907: Test Issue: Changing Group's base class to SkinnableComponent

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 8 months ago by frishy

Modified:
5 years, 3 months ago

Reviewers:
egeorgie, hmuller, evtim, rfrishbe, christianity.webb

Base URL:
http://opensource.adobe.com/svn/opensource/flex/sdk/trunk/

Visibility:
Public.

Description

This one should work, unlike the last one.

Patch Set 2 : updating patch #

Total comments: 1

Created: 15 years, 8 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -16 lines)			Patch
frameworks/projects/flex4/src/flex/component/ItemRenderer.as	View		1 chunk	+1 line, -1 line	0 comments	Download
frameworks/projects/flex4/src/flex/component/Panel.as	View		1 chunk	+2 lines, -1 line	0 comments	Download
frameworks/projects/flex4/src/flex/core/Group.as	View		1 chunk	+1 line, -1 line	0 comments	Download
frameworks/projects/flex4/src/flex/core/MXMLComponent.as	View	1	1 chunk	+6 lines, -6 lines	2 comments	Download
frameworks/projects/flex4/src/flex/core/SkinnableComponent.as	View		1 chunk	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

frishy

http://codereview.appspot.com/2907/diff/1/5 File frameworks/projects/flex4/src/flex/core/MXMLComponent.as (left): http://codereview.appspot.com/2907/diff/1/5#oldcode51 Line 51: return _selected; What are you doing here?

15 years, 8 months ago (2008-08-13 00:11:00 UTC) #2

frishy

http://codereview.appspot.com/2907/diff/1/5 File frameworks/projects/flex4/src/flex/core/MXMLComponent.as (left): http://codereview.appspot.com/2907/diff/1/5#oldcode54 Line 54: public function set selected(value:Boolean):void Test comment #2

15 years, 8 months ago (2008-08-13 00:18:25 UTC) #3

frishy

http://codereview.appspot.com/2907/diff/1/3 File frameworks/projects/flex4/src/flex/component/Panel.as (right): http://codereview.appspot.com/2907/diff/1/3#newcode19 Line 19: public class Panel extends Group really?

15 years, 8 months ago (2008-08-13 00:19:35 UTC) #4

evtim

Looks good :) http://codereview.appspot.com/2907/diff/28/11 File frameworks/projects/flex4/src/flex/core/MXMLComponent.as (right): http://codereview.appspot.com/2907/diff/28/11#newcode51 Line 51: return _selected2; Why do we ...

15 years, 8 months ago (2008-08-13 17:23:49 UTC) #6

christianity.webb

5 years, 3 months ago (2019-01-05 14:50:52 UTC) #7

there is not enough volume from Adobe's Website for chromebook2's YouTube that
came embedded.  ngvix cannot help at all.

https://codereview.appspot.com/2907/diff/28/frameworks/projects/flex4/src/fle...
File frameworks/projects/flex4/src/flex/core/MXMLComponent.as (right):

https://codereview.appspot.com/2907/diff/28/frameworks/projects/flex4/src/fle...
frameworks/projects/flex4/src/flex/core/MXMLComponent.as:51: return _selected2;
On 2008/08/13 17:23:49, evtim wrote:
> Why do we rename this? (test comment)

so that Adobe touches base with itself.

Expand All Messages | Collapse All Messages