Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(37)

Issue 2888: __findattr__ refactor (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by Leo Soto M.
Modified:
12 years, 2 months ago
Base URL:
https://jython.svn.sourceforge.net/svnroot/jython/branches/asm
Visibility:
Public.

Description

This should fix: http://bugs.jython.org/issue1041 http://bugs.jython.org/issue1095 Based on Samuele's suggestion on http://www.nabble.com/Re%3A-On-__findattr__%2C-__getattr__-and-__getattribute__-p18165384.html

Patch Set 1 #

Patch Set 2 : Suggestions applied #

Patch Set 3 : This is the actually commited patch (on r5155), in case you have more comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1060 lines, -561 lines) Patch
Lib/test/test_descr_jy.py View 1 2 3 chunks +45 lines, -2 lines 0 comments Download
src/com/ziclix/python/sql/PyConnection.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
src/com/ziclix/python/sql/PyCursor.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
src/com/ziclix/python/sql/PyExtendedCursor.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
src/com/ziclix/python/sql/PyStatement.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
src/com/ziclix/python/sql/connect/Connect.java View 1 1 chunk +2 lines, -10 lines 0 comments Download
src/com/ziclix/python/sql/connect/Connectx.java View 1 1 chunk +2 lines, -10 lines 0 comments Download
src/com/ziclix/python/sql/connect/Lookup.java View 1 1 chunk +2 lines, -2 lines 0 comments Download
src/com/ziclix/python/sql/util/BCP.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
src/org/python/core/PyArrayDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/core/PyBaseException.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
src/org/python/core/PyBaseExceptionDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/core/PyBooleanDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/core/PyClass.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
src/org/python/core/PyClassMethodDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/core/PyComplexDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/core/PyDictionaryDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/core/PyEnumerateDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/core/PyFileDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/core/PyFloatDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/core/PyFrame.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
src/org/python/core/PyFrozenSetDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/core/PyInstance.java View 1 1 chunk +1 line, -1 line 0 comments Download
src/org/python/core/PyIntegerDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/core/PyJavaClass.java View 1 1 chunk +1 line, -1 line 0 comments Download
src/org/python/core/PyJavaPackage.java View 1 1 chunk +1 line, -1 line 0 comments Download
src/org/python/core/PyListDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/core/PyLongDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/core/PyMethod.java View 1 1 chunk +17 lines, -3 lines 0 comments Download
src/org/python/core/PyModule.java View 1 1 chunk +0 lines, -15 lines 0 comments Download
src/org/python/core/PyModuleDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/core/PyObject.java View 1 4 chunks +37 lines, -19 lines 0 comments Download
src/org/python/core/PyObjectDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/core/PyPropertyDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/core/PySetDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/core/PySliceDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/core/PyStringDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/core/PySuper.java View 1 1 chunk +5 lines, -5 lines 0 comments Download
src/org/python/core/PySuperDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/core/PySystemState.java View 1 6 chunks +13 lines, -13 lines 0 comments Download
src/org/python/core/PyTableCode.java View 1 1 chunk +2 lines, -2 lines 0 comments Download
src/org/python/core/PyTupleDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/core/PyType.java View 1 2 chunks +11 lines, -6 lines 0 comments Download
src/org/python/core/PyTypeDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/core/PyUnicodeDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/modules/_csv/PyDialectDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/modules/_functools/PyPartialDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/modules/_weakref/ProxyType.java View 1 1 chunk +1 line, -1 line 0 comments Download
src/org/python/modules/_weakref/ReferenceTypeDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/modules/collections/PyDefaultDictDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/modules/collections/PyDequeDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/modules/random/PyRandomDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/modules/sre/MatchObject.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
src/org/python/modules/thread/PyLocalDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/org/python/modules/zipimport/zipimporterDerived.java View 1 1 chunk +28 lines, -14 lines 0 comments Download
src/templates/object.derived View 1 1 chunk +34 lines, -18 lines 0 comments Download

Messages

Total messages: 6
Leo Soto M.
13 years, 1 month ago (2008-08-11 03:31:05 UTC) #1
fwierzbicki
http://codereview.appspot.com/2888/diff/1/76 File src/templates/object.derived (right): http://codereview.appspot.com/2888/diff/1/76#newcode317 Line 317: return getattribute.__get__(this,self_type).__call__(py_name = PyString.fromInterned(name)); Nitpicking here, but I ...
13 years, 1 month ago (2008-08-11 04:23:52 UTC) #2
Nicholas Riley
few minor comments http://codereview.appspot.com/2888/diff/1/71 File src/com/ziclix/python/sql/connect/Connect.java (right): http://codereview.appspot.com/2888/diff/1/71#newcode36 Line 36: * Method __findattr__ Comment needs ...
13 years, 1 month ago (2008-08-11 04:45:50 UTC) #3
Leo Soto M.
http://codereview.appspot.com/2888/diff/1/71 File src/com/ziclix/python/sql/connect/Connect.java (right): http://codereview.appspot.com/2888/diff/1/71#newcode36 Line 36: * Method __findattr__ On 2008/08/11 04:45:50, Nicholas Riley ...
13 years, 1 month ago (2008-08-11 22:58:47 UTC) #4
Leo Soto M.
Suggestions applied
13 years, 1 month ago (2008-08-11 22:59:44 UTC) #5
Leo Soto M.
13 years, 1 month ago (2008-08-11 23:29:19 UTC) #6
This is the actually commited patch (on r5155), in case you have more comments
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b