Issue 286930043: src: Unify duplicated check_compact_table() and check_algorithmically()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 286930043: src: Unify duplicated check_compact_table() and check_algorithmically() (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 2 months ago by fujiwara

Modified:
8 years, 2 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

src: Unify duplicated check_compact_table() and check_algorithmically() Clean up the duplicated APIs, check_compact_table() and check_algorithmically(), in ibuscomposetable.c and ibusenginesimple.c R=Shawn.P.Huang@gmail.com Committed: 7241f66b05344b0b7caf2f83a23aa248233a955a

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+205 lines, -348 lines)			Patch
M	src/Makefile.am	View	2 chunks	+8 lines, -6 lines	0 comments	Download
M	src/ibuscomposetable.h	View	5 chunks	+8 lines, -21 lines	0 comments	Download
M	src/ibuscomposetable.c	View	16 chunks	+66 lines, -278 lines	0 comments	Download
M	src/ibusenginesimple.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/ibusenginesimple.c	View	13 chunks	+76 lines, -40 lines	0 comments	Download
A	src/ibusenginesimpleprivate.h	View	1 chunk	+44 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

fujiwara

Porting https://git.gnome.org/browse/gtk+/commit/?id=48a2477f2ddefb793e6845b14a84e715405f0c6e

8 years, 2 months ago (2016-01-29 01:53:33 UTC) #2

Peng

On 2016/01/29 01:53:33, fujiwara wrote: > Porting > https://git.gnome.org/browse/gtk+/commit/?id=48a2477f2ddefb793e6845b14a84e715405f0c6e lgtm

8 years, 2 months ago (2016-01-29 02:24:44 UTC) #3

fujiwara

8 years, 2 months ago (2016-01-29 02:54:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7241f66b05344b0b7caf2f83a23aa248233a955a (presubmit successful).

Expand All Messages | Collapse All Messages