Issue 286250043: Fix infinite recursion bug in util.Abbreviator.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 286250043: Fix infinite recursion bug in util.Abbreviator. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 2 months ago by kpreid_google

Modified:
8 years, 1 month ago

Reviewers:
MikeSamuel

CC:
google-caja-discuss_googlegroups.com

Visibility:
Public.

More Reviews

Description

If the table construction inserted "a/b/c" and then "b/c", it would fall into an infinite loop, rather than accepting that "b/c" cannot be improved on. Also add comments to the algorithm. @ 64bf67152ba4b829e45e0ae4319d9bcaea5ae030

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -14 lines)			Patch
	M	src/com/google/caja/util/Abbreviator.java	View		2 chunks	+37 lines, -11 lines	0 comments	Download
	M	tests/com/google/caja/util/AbbreviatorTest.java	View		4 chunks	+18 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

kpreid_google

On 2016/02/11 13:16:45, MikeSamuel wrote: > +1 Sorry, is that a LGTM?

8 years, 2 months ago (2016-02-11 17:50:30 UTC) #3

MikeSamuel

8 years, 2 months ago (2016-02-11 22:48:57 UTC) #4

Yes.  LGTM
On Feb 11, 2016 12:50 PM, <kpreid@google.com> wrote:

> On 2016/02/11 13:16:45, MikeSamuel wrote:
>
>> +1
>>
>
> Sorry, is that a LGTM?
>
> https://codereview.appspot.com/286250043/
>

Expand All Messages | Collapse All Messages