Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3044)

Issue 286040043: src: Use cache file for compose table for launching time (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 2 months ago by fujiwara
Modified:
8 years, 2 months ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

src: Use cache file for compose table for launching time Save the cache files of compose files under $HOME/.cache/ibus/compose for the performance. Load a compose file with the following order: 1. $HOME/.config/ibus/Compose 2. $HOME/.config/gtk-3.0/Compose 3. $HOME/.XCompose 4. /usr/share/X11/locale/$locale/Compose Check the system compose files of "el_GR", "fi_FI", "pt_BR" only for the performance because other compose files just load "en_US" compose file. BUG=https://bugzilla.gnome.org/show_bug.cgi?id=721120 R=Shawn.P.Huang@gmail.com Committed: 97e28cc04b4601295b22a0aa8e9e21ed4e0758a1

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated with comment #3. #

Total comments: 10

Patch Set 3 : Updated with comment #5. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+463 lines, -62 lines) Patch
M configure.ac View 2 chunks +10 lines, -0 lines 0 comments Download
M src/Makefile.am View 1 chunk +1 line, -0 lines 0 comments Download
M src/ibuscomposetable.h View 3 chunks +12 lines, -8 lines 0 comments Download
M src/ibuscomposetable.c View 1 2 5 chunks +353 lines, -8 lines 0 comments Download
M src/ibusenginesimple.c View 7 chunks +87 lines, -46 lines 0 comments Download

Messages

Total messages: 8
fujiwara
8 years, 2 months ago (2016-02-01 02:49:32 UTC) #1
fujiwara
Porting https://git.gnome.org/browse/gtk+/commit/?id=a41f02f9b1843e0f0085f801430e55f413a9bf9c
8 years, 2 months ago (2016-02-01 02:50:55 UTC) #2
Peng
https://codereview.appspot.com/286040043/diff/1/src/ibuscomposetable.c File src/ibuscomposetable.c (right): https://codereview.appspot.com/286040043/diff/1/src/ibuscomposetable.c#newcode513 src/ibuscomposetable.c:513: ibus_compose_table_serialize (IBusComposeTable *compose_table, How about using GVariant to do ...
8 years, 2 months ago (2016-02-01 15:15:23 UTC) #3
fujiwara
https://codereview.appspot.com/286040043/diff/1/src/ibuscomposetable.c File src/ibuscomposetable.c (right): https://codereview.appspot.com/286040043/diff/1/src/ibuscomposetable.c#newcode513 src/ibuscomposetable.c:513: ibus_compose_table_serialize (IBusComposeTable *compose_table, On 2016/02/01 15:15:23, Peng wrote: > ...
8 years, 2 months ago (2016-02-08 05:57:31 UTC) #4
Peng
https://codereview.appspot.com/286040043/diff/20001/src/ibuscomposetable.c File src/ibuscomposetable.c (right): https://codereview.appspot.com/286040043/diff/20001/src/ibuscomposetable.c#newcode535 src/ibuscomposetable.c:535: index_stride * n_seqs, Arguments do not align. https://codereview.appspot.com/286040043/diff/20001/src/ibuscomposetable.c#newcode537 src/ibuscomposetable.c:537: ...
8 years, 2 months ago (2016-02-08 15:11:01 UTC) #5
fujiwara
https://codereview.appspot.com/286040043/diff/20001/src/ibuscomposetable.c File src/ibuscomposetable.c (right): https://codereview.appspot.com/286040043/diff/20001/src/ibuscomposetable.c#newcode535 src/ibuscomposetable.c:535: index_stride * n_seqs, On 2016/02/08 15:11:00, Peng wrote: > ...
8 years, 2 months ago (2016-02-09 08:52:23 UTC) #6
Peng
On 2016/02/09 08:52:23, fujiwara wrote: > https://codereview.appspot.com/286040043/diff/20001/src/ibuscomposetable.c > File src/ibuscomposetable.c (right): > > https://codereview.appspot.com/286040043/diff/20001/src/ibuscomposetable.c#newcode535 > ...
8 years, 2 months ago (2016-02-09 15:48:19 UTC) #7
fujiwara
8 years, 2 months ago (2016-02-10 02:41:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
97e28cc04b4601295b22a0aa8e9e21ed4e0758a1 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b