Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2424)

Issue 285430043: Developer references changed to cloud, where appropriate (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 2 months ago by nstock
Modified:
6 years, 8 months ago
CC:
gsutil-crs_google.com
Visibility:
Public.

Description

--Change from "Google Developer Console" to "Google Cloud Platform Console" --Change most of the developer.google.com links to equivalent cloud.google.com. --Change console.developers.google.com to console.cloud.google.com

Patch Set 1 #

Total comments: 12

Patch Set 2 : Address comments #

Total comments: 2

Patch Set 3 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -30 lines) Patch
M gslib/__main__.py View 1 chunk +1 line, -1 line 0 comments Download
M gslib/addlhelp/acls.py View 1 chunk +1 line, -1 line 0 comments Download
M gslib/addlhelp/projects.py View 1 3 chunks +4 lines, -3 lines 0 comments Download
M gslib/addlhelp/support.py View 2 chunks +2 lines, -2 lines 0 comments Download
M gslib/addlhelp/versions.py View 1 chunk +1 line, -1 line 0 comments Download
M gslib/boto_resumable_upload.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gslib/command_runner.py View 1 chunk +1 line, -1 line 0 comments Download
M gslib/commands/compose.py View 1 chunk +1 line, -1 line 0 comments Download
M gslib/commands/cp.py View 2 chunks +2 lines, -2 lines 0 comments Download
M gslib/commands/lifecycle.py View 1 chunk +1 line, -1 line 0 comments Download
M gslib/commands/logging.py View 1 chunk +1 line, -1 line 0 comments Download
M gslib/commands/notification.py View 1 3 chunks +3 lines, -3 lines 0 comments Download
M gslib/commands/signurl.py View 1 4 chunks +7 lines, -7 lines 0 comments Download
M gslib/commands/web.py View 1 chunk +1 line, -1 line 0 comments Download
M gslib/gcs_json_api.py View 1 chunk +2 lines, -2 lines 0 comments Download
M setup.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12
nstock
8 years, 2 months ago (2016-02-09 18:27:49 UTC) #1
mfschwartz
https://codereview.appspot.com/285430043/diff/1/gslib/boto_resumable_upload.py File gslib/boto_resumable_upload.py (left): https://codereview.appspot.com/285430043/diff/1/gslib/boto_resumable_upload.py#oldcode25 gslib/boto_resumable_upload.py:25: for details. How about switching to https://cloud.google.com/storage/docs/resumable-uploads-xml instead of ...
8 years, 2 months ago (2016-02-09 18:41:45 UTC) #2
thobrla
https://codereview.appspot.com/285430043/diff/1/gslib/addlhelp/projects.py File gslib/addlhelp/projects.py (right): https://codereview.appspot.com/285430043/diff/1/gslib/addlhelp/projects.py#newcode91 gslib/addlhelp/projects.py:91: project ID or the project number from the Google ...
8 years, 2 months ago (2016-02-09 18:48:25 UTC) #3
nstock
Fixed 4 comments; just need confirmation on resumable upload comment. https://codereview.appspot.com/285430043/diff/1/gslib/addlhelp/projects.py File gslib/addlhelp/projects.py (right): https://codereview.appspot.com/285430043/diff/1/gslib/addlhelp/projects.py#newcode91 ...
8 years, 2 months ago (2016-02-09 19:05:40 UTC) #4
Mike Schwartz
https://codereview.appspot.com/285430043/diff/1/gslib/boto_resumable_upload.py File gslib/boto_resumable_upload.py (left): https://codereview.appspot.com/285430043/diff/1/gslib/boto_resumable_upload.py#oldcode25 gslib/boto_resumable_upload.py:25: for details. On 2016/02/09 19:05:40, nstock wrote: > On ...
8 years, 2 months ago (2016-02-09 19:09:51 UTC) #5
nstock
All comments addressed. Question: Do I re-run "python ~/Desktop/upload.py --rev origin/HEAD" to make changes visible ...
8 years, 2 months ago (2016-02-09 19:15:31 UTC) #6
thobrla
To upload your newest patchset, you'll do something like: python upload.py -i 285430043 --rev xxxxxx:yyyyyy ...
8 years, 2 months ago (2016-02-09 19:23:55 UTC) #7
nstock
Great, thanks! Issue should be update; comments should be addressed
8 years, 2 months ago (2016-02-09 19:30:06 UTC) #8
thobrla
https://codereview.appspot.com/285430043/diff/20001/gslib/boto_resumable_upload.py File gslib/boto_resumable_upload.py (right): https://codereview.appspot.com/285430043/diff/20001/gslib/boto_resumable_upload.py#newcode23 gslib/boto_resumable_upload.py:23: Unnecessary whitespace
8 years, 2 months ago (2016-02-09 19:32:15 UTC) #9
nstock
https://codereview.appspot.com/285430043/diff/20001/gslib/boto_resumable_upload.py File gslib/boto_resumable_upload.py (right): https://codereview.appspot.com/285430043/diff/20001/gslib/boto_resumable_upload.py#newcode23 gslib/boto_resumable_upload.py:23: On 2016/02/09 19:32:15, thobrla wrote: > Unnecessary whitespace Done.
8 years, 2 months ago (2016-02-09 19:37:23 UTC) #10
thobrla
LGTM Make sure to squash your commits before submitting.
8 years, 2 months ago (2016-02-09 19:43:28 UTC) #11
mfschwartz
8 years, 2 months ago (2016-02-09 20:42:53 UTC) #12
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b