Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(625)

Issue 28310043: Fix #1245427: help for juju ssh is slightly wrong

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by abel.deuring
Modified:
10 years, 4 months ago
Reviewers:
mp+195595, jameinel, rog
Visibility:
Public.

Description

Fix #1245427: help for juju ssh is slightly wrong As described in the bug report "juju ssh -h" prints usage: juju ssh [options] <service> [<ssh args>...] which is a bit misleading since "service" has its own meaning in juju. I replaced "service" with "target". https://code.launchpad.net/~adeuring/juju-core/1245427/+merge/195595 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix #1245427: help for juju ssh is slightly wrong #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/cmd_test.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/ssh.go View 1 2 chunks +16 lines, -5 lines 1 comment Download

Messages

Total messages: 9
abel.deuring
Please take a look.
10 years, 4 months ago (2013-11-18 12:31:56 UTC) #1
rog
On 2013/11/18 12:31:56, abel.deuring wrote: > Please take a look. LGTM. good change, thanks.
10 years, 4 months ago (2013-11-18 12:35:30 UTC) #2
jameinel
I think this is a good change and would be happy to see it land. ...
10 years, 4 months ago (2013-11-18 12:43:44 UTC) #3
abel.deuring
Please take a look.
10 years, 4 months ago (2013-11-18 13:40:56 UTC) #4
abel.deuring
On 2013/11/18 12:43:44, jameinel wrote: > I think this is a good change and would ...
10 years, 4 months ago (2013-11-18 13:42:14 UTC) #5
rog
The examples LGTM too, with one minor typo. https://codereview.appspot.com/28310043/diff/20001/cmd/juju/ssh.go File cmd/juju/ssh.go (right): https://codereview.appspot.com/28310043/diff/20001/cmd/juju/ssh.go#newcode42 cmd/juju/ssh.go:42: Connect ...
10 years, 4 months ago (2013-11-18 14:01:31 UTC) #6
abel.deuring
On 2013/11/18 14:01:31, rog wrote: > The examples LGTM too, with one minor typo. > ...
10 years, 4 months ago (2013-11-18 14:09:58 UTC) #7
rog
>> cmd/juju/ssh.go:42: Connect to the second mysql unit: >> s/second/first/ > > > no, I ...
10 years, 4 months ago (2013-11-18 14:32:50 UTC) #8
abel.deuring
10 years, 4 months ago (2013-11-18 14:54:09 UTC) #9
On 2013/11/18 14:32:50, rog wrote:
> >> cmd/juju/ssh.go:42: Connect to the second mysql unit:
> >> s/second/first/
> >
> >
> > no, I think "second" right. The first unit would be "mysql/0"
> 
> mysql/0 is what I see there. Am I missing something?

ouch... right, I _thought that I showed "juju ssh mysql/1". Swiitched that to /0
now.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b