Issue 282540043: Added initial version of StorageReader #102

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 282540043: Added initial version of StorageReader #102 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 2 months ago by Joachim Metz

Modified:
8 years, 2 months ago

Reviewers:
onager

CC:
kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

Added initial version of StorageReader #102

Patch Set 2 : Changes after review. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+228 lines, -177 lines)			Patch
M	plaso/engine/queue.py	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	plaso/frontend/psort.py	View		4 chunks	+55 lines, -55 lines	0 comments	Download
A	plaso/storage/reader.py	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download
M	plaso/storage/zip_file.py	View	1	4 chunks	+35 lines, -22 lines	0 comments	Download
M	tests/frontend/extraction_frontend.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/frontend/psort.py	View		4 chunks	+19 lines, -13 lines	0 comments	Download
M	tests/output/pstorage.py	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	tests/storage/zip_file.py	View	1	2 chunks	+72 lines, -71 lines	0 comments	Download
M	tools/psort.py	View		1 chunk	+11 lines, -9 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

onager

LGTM, one docstring nit. https://codereview.appspot.com/282540043/diff/1/plaso/storage/reader.py File plaso/storage/reader.py (right): https://codereview.appspot.com/282540043/diff/1/plaso/storage/reader.py#newcode2 plaso/storage/reader.py:2: """The storage reader objects.""" This ...

8 years, 2 months ago (2016-02-15 20:16:01 UTC) #2

Joachim Metz

https://codereview.appspot.com/282540043/diff/1/plaso/storage/reader.py File plaso/storage/reader.py (right): https://codereview.appspot.com/282540043/diff/1/plaso/storage/reader.py#newcode2 plaso/storage/reader.py:2: """The storage reader objects.""" On 2016/02/15 20:16:01, onager wrote: ...

8 years, 2 months ago (2016-02-15 20:32:01 UTC) #3

Joachim Metz

8 years, 2 months ago (2016-02-15 20:41:04 UTC) #5

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close storage1

Expand All Messages | Collapse All Messages