Issue 280230043: Bug 1229942 - Remove enableSSL2 and v2CompatibleHello from sslOptionsStr

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 280230043: Bug 1229942 - Remove enableSSL2 and v2CompatibleHello from sslOptionsStr (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 4 months ago by ttaubert

Modified:
8 years, 2 months ago

Reviewers:
ekr, mt, ekr-rietveld

Visibility:
Public.

More Reviews

Description

Bug 1229942 - Remove enableSSL2 and v2CompatibleHello from sslOptionsStr

Patch Set 1 #

Total comments: 8

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -214 lines)			Patch
M	lib/ssl/sslcon.c	View	13 chunks	+20 lines, -189 lines	4 comments	Download
M	lib/ssl/sslimpl.h	View	1 chunk	+21 lines, -23 lines	2 comments	Download
M	lib/ssl/sslsock.c	View	1 chunk	+0 lines, -2 lines	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

I think that there are a few things off here. https://codereview.appspot.com/280230043/diff/1/lib/ssl/sslcon.c File lib/ssl/sslcon.c (right): https://codereview.appspot.com/280230043/diff/1/lib/ssl/sslcon.c#newcode130 ...

8 years, 4 months ago (2015-12-03 21:42:05 UTC) #1

ttaubert

8 years, 2 months ago (2016-01-27 14:40:08 UTC) #2

https://codereview.appspot.com/280230043/diff/1/lib/ssl/sslcon.c
File lib/ssl/sslcon.c (right):

https://codereview.appspot.com/280230043/diff/1/lib/ssl/sslcon.c#newcode130
lib/ssl/sslcon.c:130: ssl2_ConstructCipherSpecs(sslSocket *ss)
On 2015/12/03 21:42:05, mt wrote:
> I have to admit that I don't understand this code very well.  I'll have to
have
> another look before I can decide if these changes are right.  However, I
suspect
> that a lot of this isn't needed at all and I don't want to spend time
> understanding code that is going to be removed.  That's what's hard with
> piecemeal removal.

Fair enough, I'll look into that some more before submitting the next version.

https://codereview.appspot.com/280230043/diff/1/lib/ssl/sslcon.c#newcode133
lib/ssl/sslcon.c:133: int 		ssl3_count	= 0;
On 2015/12/03 21:42:05, mt wrote:
> rename this to suite_count

Done.

https://codereview.appspot.com/280230043/diff/1/lib/ssl/sslimpl.h
File lib/ssl/sslimpl.h (right):

https://codereview.appspot.com/280230043/diff/1/lib/ssl/sslimpl.h#newcode318
lib/ssl/sslimpl.h:318: unsigned int unusedBit9		: 1;  /*  8 */
On 2015/12/03 21:42:05, mt wrote:
> You need to leave the bit in place here.

Done.

https://codereview.appspot.com/280230043/diff/1/lib/ssl/sslsock.c
File lib/ssl/sslsock.c (left):

https://codereview.appspot.com/280230043/diff/1/lib/ssl/sslsock.c#oldcode66
lib/ssl/sslsock.c:66: PR_FALSE,   /* enableSSL2         */ /* now defaults to
off in NSS 3.13 */
On 2015/12/03 21:42:05, mt wrote:
> You should probably leave this in place, unless you are renumbering options.

Done.

Expand All Messages | Collapse All Messages