Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6303)

Issue 277120043: Removing unused features. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 5 months ago by the80srobot
Modified:
8 years, 5 months ago
CC:
rekall-dev_googlegroups.com
Base URL:
git@github.com:google/dotty.git@master
Visibility:
Public.

Description

Removing unused features. I am removing the hint transform because it was primarily used by the Rekall entities stack. Query rewriting is still a feature I want EFILTER to offer, but it requires a more thoughtful approach. In absence of a pressing need for this feature (now that entities are on the backburner) I am removing the code for now, rather than spending time implementing it over the new AST types. BUG= R=joachim.metz@gmail.com Committed: 109aa56c289c0ce9d62015b901ffb6444a76d2f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -414 lines) Patch
M efilter/transforms/aslisp.py View 1 chunk +1 line, -1 line 0 comments Download
D efilter/transforms/hint.py View 1 chunk +0 lines, -190 lines 0 comments Download
M efilter_tests/coverage/transforms.py View 2 chunks +0 lines, -4 lines 0 comments Download
M efilter_tests/coverage/units.py View 3 chunks +0 lines, -5 lines 0 comments Download
D efilter_tests/integration/planning.py View 1 chunk +0 lines, -84 lines 0 comments Download
M efilter_tests/unit/query.py View 2 chunks +0 lines, -5 lines 0 comments Download
D efilter_tests/unit/transforms/hint.py View 1 chunk +0 lines, -125 lines 0 comments Download

Messages

Total messages: 4
the80srobot
8 years, 5 months ago (2015-11-28 19:37:53 UTC) #1
the80srobot
This also removes an unused integration test case - this was there to test a ...
8 years, 5 months ago (2015-11-28 19:39:23 UTC) #2
Joachim Metz
LGTM
8 years, 5 months ago (2015-11-28 22:53:48 UTC) #3
the80srobot
8 years, 5 months ago (2015-11-29 09:29:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
109aa56c289c0ce9d62015b901ffb6444a76d2f2 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b