Issue 273570043: Draft of more granular worker statuses. Partial fix for #399.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 273570043: Draft of more granular worker statuses. Partial fix for #399. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 4 months ago by onager

Modified:
8 years, 4 months ago

Reviewers:
Joachim Metz, kiddi, onager

CC:
log2timeline-dev_googlegroups.com

Visibility:
Public.

Draft of more granular worker statuses. Partial fix for #399.

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -4 lines)			Patch
M	plaso/engine/processing_status.py	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	plaso/engine/worker.py	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	plaso/lib/definitions.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	plaso/multi_processing/multi_process.py	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	tools/log2timeline.py	View	2 chunks	+6 lines, -2 lines	0 comments	Download

Total messages: 4

onager

On 2015/11/27 16:23:05, onager wrote: This is one approach for fixing #399, seeking feedback on ...

8 years, 4 months ago (2015-11-27 16:25:07 UTC) #2

Joachim Metz

Let's sync on this. Seems like this could work to fix the issue but I'm ...

8 years, 4 months ago (2015-11-27 16:41:41 UTC) #3

Joachim Metz

8 years, 4 months ago (2015-12-03 07:30:40 UTC) #4

LGTM, as discussed agree with the approach for the short term but let's make
sure to revisit this in the near future.