Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1732)

Issue 2735044: Doc: move non-Western languages to world.itely (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by Valentin Villenave
Modified:
7 years, 8 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: move non-Western languages to world.itely

Patch Set 1 #

Total comments: 14

Patch Set 2 : Replace @file with @code, and a few nitpicks #

Patch Set 3 : Oh, and add glossary entry for CPP. #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+354 lines, -306 lines) Patch
M Documentation/de/notation/pitches.itely View 2 chunks +3 lines, -64 lines 0 comments Download
M Documentation/de/notation/world.itely View 1 chunk +65 lines, -0 lines 0 comments Download
M Documentation/es/notation/pitches.itely View 2 chunks +3 lines, -63 lines 0 comments Download
M Documentation/es/notation/world.itely View 1 chunk +64 lines, -0 lines 0 comments Download
M Documentation/fr/notation/pitches.itely View 2 chunks +3 lines, -65 lines 0 comments Download
M Documentation/fr/notation/world.itely View 1 chunk +65 lines, -0 lines 0 comments Download
M Documentation/music-glossary.tely View 2 chunks +22 lines, -0 lines 2 comments Download
M Documentation/notation/pitches.itely View 1 2 3 chunks +61 lines, -114 lines 0 comments Download
M Documentation/notation/world.itely View 1 chunk +68 lines, -0 lines 2 comments Download

Messages

Total messages: 11
Valentin Villenave
Greetings, new patch.
7 years, 8 months ago (2010-10-29 09:26:14 UTC) #1
Trevor Daniels
Looks fine generally, but some editorial changes are needed. Trevor http://codereview.appspot.com/2735044/diff/1/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): http://codereview.appspot.com/2735044/diff/1/Documentation/notation/pitches.itely#newcode459 ...
7 years, 8 months ago (2010-10-29 10:15:46 UTC) #2
Graham Percival (old account)
Generally ok, but I don't know why you're changing the translations before the English docs ...
7 years, 8 months ago (2010-10-29 10:37:15 UTC) #3
Valentin Villenave
Hi guys, here's a new patch set. In case that wasn't clear, this commit is ...
7 years, 8 months ago (2010-10-29 11:58:00 UTC) #4
Graham Percival (old account)
LGTM. My nitpick doesn't require a new draft version; if there are no other complaints, ...
7 years, 8 months ago (2010-10-29 12:07:02 UTC) #5
Carl
LGTM, but I have an organization question. Carl http://codereview.appspot.com/2735044/diff/8001/Documentation/notation/world.itely File Documentation/notation/world.itely (right): http://codereview.appspot.com/2735044/diff/8001/Documentation/notation/world.itely#newcode42 Documentation/notation/world.itely:42: @notation{Turkish ...
7 years, 8 months ago (2010-10-29 12:53:41 UTC) #6
Valentin Villenave
http://codereview.appspot.com/2735044/diff/8001/Documentation/music-glossary.tely File Documentation/music-glossary.tely (right): http://codereview.appspot.com/2735044/diff/8001/Documentation/music-glossary.tely#newcode2008 Documentation/music-glossary.tely:2008: @uref{http://en.wikipedia.org/wiki/Common_practice_period, On 2010/10/29 12:07:02, Graham Percival wrote: > Ouch. ...
7 years, 8 months ago (2010-10-29 12:59:46 UTC) #7
Trevor Daniels
OK, it's an improvement so go ahead and push, but "musics" grates so much I'd ...
7 years, 8 months ago (2010-10-29 13:12:13 UTC) #8
Carl
On 2010/10/29 13:12:13, Trevor Daniels wrote: > OK, it's an improvement so go ahead and ...
7 years, 8 months ago (2010-10-29 13:26:01 UTC) #9
Valentin Villenave
On Fri, Oct 29, 2010 at 3:12 PM, <tdanielsmusic@googlemail.com> wrote: > OK, it's an improvement ...
7 years, 8 months ago (2010-10-29 13:44:40 UTC) #10
Graham Percival
7 years, 8 months ago (2010-10-29 13:52:50 UTC) #11
On Fri, Oct 29, 2010 at 01:12:13PM +0000, tdanielsmusic@googlemail.com wrote:
> OK, it's an improvement so go ahead and push, but "musics" grates so
> much I'd definitely have removed it as part of this patch.

:)

Ok, we're agreed.  We *all* hate the material which is moving into
world.itely, but since none of us wrote it, let's just shove it
into world.itely and leave it for somebody else to fix.  I mean,
it definitely makes the "real" (i.e. non-ghetto-ized) part of the
manual better.

Cheers,
- Graham
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b