Issue 270760043: update nightly.cmake comment about CDash setup

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 270760043: update nightly.cmake comment about CDash setup

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 6 months ago by zhaoqin

Modified:
8 years, 6 months ago

Reviewers:
bruening

CC:
dynamorio-devs_googlegroups.com

Visibility:
Public.

More Reviews

Description

Commit log for first patchset: --------------- update nightly.cmake comment about CDash setup - add xref to cmake nightly binaries download ---------------

Patch Set 1 #

Patch Set 2 : Committed #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	suite/nightly.cmake	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bruening

Use i#1795 subject line similar to prior commit for continuity in commit msg. Otherwise LGTM

8 years, 6 months ago (2015-10-09 16:03:51 UTC) #2

zhaoqin

8 years, 6 months ago (2015-10-09 20:14:31 UTC) #3

Committed as
https://github.com/DynamoRIO/dynamorio/commit/f8c634b867d179e840866cd9ef0ee42...

Final commit log: 
---------------
i#1795 revive CDash server: update nightly.cmake comment about CDash setup

- add xref to cmake nightly binaries download

Review-URL: https://codereview.appspot.com/270760043
---------------

Expand All Messages | Collapse All Messages