Issue 269230043: codereview test with cl

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 269230043: codereview test with cl

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 6 months ago by maliha

Modified:
8 years, 4 months ago

Reviewers:
elbashir, katsikas, nkoutsou, jiakun, dmk, yitingy, chenghu

Base URL:
git@gits-14.sys.kth.se:nkoutsou/NSC.git@codereview

Visibility:
Public.

More Reviews

Description

codereview test with cl BUG=

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : gui update #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1641 lines, -190 lines)			Patch
A +	GUI/gui_topology/gui_topology/html/dist/css/animsition.css	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	GUI/gui_topology/gui_topology/html/dist/css/animsition.css.map	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	GUI/gui_topology/gui_topology/html/dist/css/animsition.min.css	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	GUI/gui_topology/gui_topology/html/dist/js/jquery.animsition.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	GUI/gui_topology/gui_topology/html/dist/js/jquery.animsition.min.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	GUI/gui_topology/gui_topology/html/dist/js/jquery.min.js	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	GUI/gui_topology/gui_topology/html/home.html	View	1 2	5 chunks	+7 lines, -7 lines	0 comments	Download
A +	GUI/gui_topology/gui_topology/html/home/css	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	GUI/gui_topology/gui_topology/html/home/define.png	View	1 2	Binary file		0 comments	Download
A +	GUI/gui_topology/gui_topology/html/home/latin.css	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	GUI/gui_topology/gui_topology/html/home/mobileIEFix.css	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	GUI/gui_topology/gui_topology/html/home/monitor.png	View	1 2	Binary file		0 comments	Download
A +	GUI/gui_topology/gui_topology/html/home/topo.png	View	1 2	Binary file		0 comments	Download
A +	GUI/gui_topology/gui_topology/html/home/viewer.css	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	GUI/gui_topology/gui_topology/html/index.html	View	1 2	1 chunk	+323 lines, -144 lines	0 comments	Download
M	GUI/gui_topology/gui_topology/html/latency.html	View	1 2	2 chunks	+609 lines, -21 lines	0 comments	Download
M	GUI/gui_topology/gui_topology/html/monitoring_module.html	View	1 2	4 chunks	+714 lines, -30 lines	0 comments	Download
A +	GUI/gui_topology/gui_topology/html/source_files/css	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	GUI/gui_topology/gui_topology/html/source_files/latin.css	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	GUI/gui_topology/gui_topology/html/source_files/mobileIEFix.css	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	nsc_topology/nf_policies.html	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

code review! 
got it working now (i think)

Expand All Messages | Collapse All Messages