i#1734 create Dr. Fuzz: move fuzz tests into tests/fuzz/

Commit log for first patchset:
---------------
i#1734 create Dr. Fuzz: move fuzz tests into tests/fuzz/

- move all fuzz tests into tests/fuzz/
- add newfuzztest* functions in tests/CMakeLists.txt
---------------

[bruening, 2015-10-09 14:43:30]

Maybe tests/fuzzer/ to match drmemory/fuzzer.c?  Not sure, fuzz/ is ok.

Also, the other tests/ subdirs have their own CMakeLists.txt that adds their
tests: should we do that here?

https://codereview.appspot.com/269220043/diff/1/tests/CMakeLists.txt
File tests/CMakeLists.txt (right):

https://codereview.appspot.com/269220043/diff/1/tests/CMakeLists.txt#newcode267
tests/CMakeLists.txt:267: exit_code path_append res_path)
This is not necessary: just put the subdir inside resbase

[zhaoqin, 2015-10-09 20:59:20]

On 2015/10/09 14:43:30, bruening wrote:
> Maybe tests/fuzzer/ to match drmemory/fuzzer.c?  Not sure, fuzz/ is ok.

I was thinking 3 possible names: drfuzz, fuzzer, and fuzz. I can go with fuzzer
or fuzz. Prefer fuzz.

> 
> Also, the other tests/ subdirs have their own CMakeLists.txt that adds their
> tests: should we do that here?

I was following the DynamoRIO tests, where subdir like client-interface does
need another CMakeLists.txt, but I can add it to be consistent on Dr. Memory.

> 
> https://codereview.appspot.com/269220043/diff/1/tests/CMakeLists.txt
> File tests/CMakeLists.txt (right):
> 
>
https://codereview.appspot.com/269220043/diff/1/tests/CMakeLists.txt#newcode267
> tests/CMakeLists.txt:267: exit_code path_append res_path)
> This is not necessary: just put the subdir inside resbase

There is code like:
  if ("${resbase}" STREQUAL "")
    set(resbase "${test}")
    string(REGEX REPLACE "_FLAKY$" "" resbase "${resbase}")
  endif ("${resbase}" STREQUAL "")
which prevents me from using resbase directly.

[bruening, 2015-10-09 21:20:12]

On 2015/10/09 20:59:20, zhaoqin wrote:
> On 2015/10/09 14:43:30, bruening wrote:
>
https://codereview.appspot.com/269220043/diff/1/tests/CMakeLists.txt#newcode267
> > tests/CMakeLists.txt:267: exit_code path_append res_path)
> > This is not necessary: just put the subdir inside resbase
> 
> There is code like:
>   if ("${resbase}" STREQUAL "")
>     set(resbase "${test}")
>     string(REGEX REPLACE "_FLAKY$" "" resbase "${resbase}")
>   endif ("${resbase}" STREQUAL "")
> which prevents me from using resbase directly.

Please reply on the comment -- it makes it easier to track, rather than
top-level here.  I don't follow why this prevents you: if the string is not
empty, which it won't be, that code is not run.

[zhaoqin, 2015-10-12 21:57:02]

Commit log for latest patchset:
---------------
i#1734 create Dr. Fuzz: move fuzz tests into tests/fuzz/

- move all fuzz tests into tests/fuzz/
- add tests/fuzz/CMakeLists.txt

Review-URL: https://codereview.appspot.com/269220043
---------------

[bruening, 2015-10-13 19:49:07]

LGTM except for the one line I commented on

https://codereview.appspot.com/269220043/diff/20001/tests/fuzz/CMakeLists.txt
File tests/fuzz/CMakeLists.txt (right):

https://codereview.appspot.com/269220043/diff/20001/tests/fuzz/CMakeLists.txt...
tests/fuzz/CMakeLists.txt:21: # XXX i#1652: make this a separate project and use
--build-and-test
I don't follow -- why would we do that?  Doesn't make sense for sthg internal to
DrMem.

[zhaoqin, 2015-10-13 22:39:42]

Committed as
https://github.com/DynamoRIO/drmemory/commit/a0c0386d5129957d9547cd2b8b543341...

Final commit log: 
---------------
i#1734 create Dr. Fuzz: move fuzz tests into tests/fuzz/

- move all fuzz tests into tests/fuzz/
- add tests/fuzz/CMakeLists.txt

Review-URL: https://codereview.appspot.com/269220043
---------------