Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1284)

Issue 267260043: Storage added timestamp table object #102 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 5 months ago by Joachim Metz
Modified:
8 years, 5 months ago
Reviewers:
Joachim Metz, kiddi, onager
CC:
log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

Storage added timestamp table object #102 Depends on: 262660043

Patch Set 1 #

Patch Set 2 : Storage added timestamp table object #102 #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+445 lines, -283 lines) Patch
M plaso/storage/zip_file.py View 1 23 chunks +385 lines, -276 lines 8 comments Download
M tests/frontend/psort.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/storage/zip_file.py View 3 chunks +59 lines, -6 lines 0 comments Download

Messages

Total messages: 5
Joachim Metz
8 years, 5 months ago (2015-10-08 07:17:21 UTC) #1
Joachim Metz
Code updated.
8 years, 5 months ago (2015-10-09 06:21:37 UTC) #2
Joachim Metz
https://codereview.appspot.com/267260043/diff/20001/plaso/storage/zip_file.py File plaso/storage/zip_file.py (right): https://codereview.appspot.com/267260043/diff/20001/plaso/storage/zip_file.py#newcode1835 plaso/storage/zip_file.py:1835: old_tag = self._ReadEventTag(data_stream) Add note about tag write, cache ...
8 years, 5 months ago (2015-10-09 09:45:09 UTC) #3
onager
LGTM, minor comments. https://codereview.appspot.com/267260043/diff/20001/plaso/storage/zip_file.py File plaso/storage/zip_file.py (right): https://codereview.appspot.com/267260043/diff/20001/plaso/storage/zip_file.py#newcode702 plaso/storage/zip_file.py:702: # TODO: determine if else needs ...
8 years, 5 months ago (2015-10-13 09:36:45 UTC) #4
Joachim Metz
8 years, 5 months ago (2015-10-13 18:40:59 UTC) #5
https://codereview.appspot.com/267260043/diff/20001/plaso/storage/zip_file.py
File plaso/storage/zip_file.py (right):

https://codereview.appspot.com/267260043/diff/20001/plaso/storage/zip_file.py...
plaso/storage/zip_file.py:702: # TODO: determine if else needs to be handled
here.
On 2015/10/13 09:36:45, onager wrote:
> +anything

Done.

https://codereview.appspot.com/267260043/diff/20001/plaso/storage/zip_file.py...
plaso/storage/zip_file.py:1186: self._pre_obj.counter[attributes.get(u'parser',
u'N/A')] += 1
On 2015/10/13 09:36:45, onager wrote:
> Add todo to remove plugin, add parser chain. I also think this should be moved
> to a separate method to modularize this code a little more -
UpdateEventCounters
> or something.

Done.

https://codereview.appspot.com/267260043/diff/20001/plaso/storage/zip_file.py...
plaso/storage/zip_file.py:1427: report_string =
file_object.read(self.MAXIMUM_REPORT_PROTOBUF_SIZE)
On 2015/10/13 09:36:45, onager wrote:
> not report_data or report_bytes?

leaving as-is

https://codereview.appspot.com/267260043/diff/20001/plaso/storage/zip_file.py...
plaso/storage/zip_file.py:1835: old_tag = self._ReadEventTag(data_stream)
On 2015/10/09 09:45:09, Joachim Metz wrote:
> Add note about tag write, cache invalidation.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b