Issue 266320043: CStr class for UnicodeString as const char *

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 266320043: CStr class for UnicodeString as const char * (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 6 months ago by andy.heninger

Modified:
6 years, 8 months ago

Reviewers:
andy.heninger, markus.icu

Base URL:
svn+ssh://source.icu-project.org/repos/icu/icu/branches/andy/11857/

Visibility:
Public.

More Reviews

Description

CStr class for UnicodeString as const char *

Patch Set 2 : ticket:11857 CStr, Markus's review comments. #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
	M	common/cstr.h	View	1	1 chunk	+3 lines, -5 lines	0 comments	Download
	M	test/depstest/dependencies.txt	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

markus.icu

https://codereview.appspot.com/266320043/diff/1/source/common/cstr.h File source/common/cstr.h (right): https://codereview.appspot.com/266320043/diff/1/source/common/cstr.h#newcode29 source/common/cstr.h:29: * Usage: CStr(aUnicodeString)() The example below is better than ...

8 years, 6 months ago (2015-10-08 18:23:37 UTC) #2

andy.heninger

8 years, 6 months ago (2015-10-08 20:10:35 UTC) #3

LGTM

Expand All Messages | Collapse All Messages