Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(161)

Issue 26500043: code review 26500043: go.tools/ssa/interp: fix Plan 9 build for Brad (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by ality
Modified:
7 years, 11 months ago
Reviewers:
rsc
CC:
golang-codereviews, rsc, 0intro
Visibility:
Public.

Description

go.tools/ssa/interp: fix Plan 9 build for Brad

Patch Set 1 #

Patch Set 2 : diff -r 6b12c0090dfb https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 6b12c0090dfb https://code.google.com/p/go.tools #

Total comments: 1

Patch Set 4 : diff -r f04dbdcae7c4 https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M ssa/interp/external.go View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M ssa/interp/external_plan9.go View 1 2 chunks +3 lines, -2 lines 0 comments Download
M ssa/interp/external_unix.go View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ssa/interp/external_windows.go View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7
ality
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.tools
8 years ago (2013-11-14 09:57:12 UTC) #1
rsc
LGTM https://codereview.appspot.com/26500043/diff/40001/ssa/interp/external_windows.go File ssa/interp/external_windows.go (right): https://codereview.appspot.com/26500043/diff/40001/ssa/interp/external_windows.go#newcode5 ssa/interp/external_windows.go:5: // +build windows this line does nothing: the ...
8 years ago (2013-11-14 15:20:25 UTC) #2
rsc
Is this going to be submitted?
7 years, 11 months ago (2013-12-20 02:33:43 UTC) #3
0intro
It works for me. I think it could be submitted.
7 years, 11 months ago (2013-12-20 05:41:33 UTC) #4
rsc
ality, could you remove the unnecessary build tag and then submit?
7 years, 11 months ago (2013-12-20 15:30:44 UTC) #5
gobot
Replacing golang-dev with golang-codereviews.
7 years, 11 months ago (2013-12-20 16:26:09 UTC) #6
ality
7 years, 11 months ago (2013-12-20 23:21:35 UTC) #7
*** Submitted as
https://code.google.com/p/go/source/detail?r=74a773d5732f&repo=tools ***

go.tools/ssa/interp: fix Plan 9 build for Brad

R=golang-codereviews, rsc, 0intro
CC=golang-codereviews
https://codereview.appspot.com/26500043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b