Issue 26500043: code review 26500043: go.tools/ssa/interp: fix Plan 9 build for Brad

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 26500043: code review 26500043: go.tools/ssa/interp: fix Plan 9 build for Brad (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by ality

Modified:
10 years, 4 months ago

Reviewers:
rsc

CC:
golang-codereviews, rsc, 0intro

Visibility:
Public.

Description

go.tools/ssa/interp: fix Plan 9 build for Brad

Patch Set 2 : diff -r 6b12c0090dfb https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 6b12c0090dfb https://code.google.com/p/go.tools #

Total comments: 1

Patch Set 4 : diff -r f04dbdcae7c4 https://code.google.com/p/go.tools #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -8 lines)			Patch
M	ssa/interp/external.go	View	1 2 3	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ssa/interp/external_plan9.go	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	ssa/interp/external_unix.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ssa/interp/external_windows.go	View	1 2 3	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

ality

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.tools

10 years, 5 months ago (2013-11-14 09:57:12 UTC) #1

rsc

LGTM https://codereview.appspot.com/26500043/diff/40001/ssa/interp/external_windows.go File ssa/interp/external_windows.go (right): https://codereview.appspot.com/26500043/diff/40001/ssa/interp/external_windows.go#newcode5 ssa/interp/external_windows.go:5: // +build windows this line does nothing: the ...

10 years, 5 months ago (2013-11-14 15:20:25 UTC) #2

rsc

ality, could you remove the unnecessary build tag and then submit?

10 years, 4 months ago (2013-12-20 15:30:44 UTC) #5

ality

10 years, 4 months ago (2013-12-20 23:21:35 UTC) #7

*** Submitted as
https://code.google.com/p/go/source/detail?r=74a773d5732f&repo=tools ***

go.tools/ssa/interp: fix Plan 9 build for Brad

R=golang-codereviews, rsc, 0intro
CC=golang-codereviews
https://codereview.appspot.com/26500043

Expand All Messages | Collapse All Messages