Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(8885)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
264170043
: Initial support for file entry attributes. (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by
Joachim Metz
Modified:
8 years, 7 months ago
Reviewers:
Joachim Metz
,
kiddi
,
onager
CC:
log2timeline-dev_googlegroups.com
Visibility:
Public.
More Reviews
Description
Initial support for file entry attributes. Requires: 235930043
Patch Set 1 : Initial support for file entry attributes.
#
Patch Set 2 : Code updated.
#
Created:
8 years, 7 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+386 lines, -46 lines
)
Patch
M
dfvfs/lib/date_time.py
View
5 chunks
+17 lines, -9 lines
0 comments
Download
M
dfvfs/lib/definitions.py
View
1 chunk
+5 lines, -0 lines
0 comments
Download
M
dfvfs/vfs/file_entry.py
View
15 chunks
+55 lines, -19 lines
0 comments
Download
M
dfvfs/vfs/ntfs_file_entry.py
View
1
3 chunks
+156 lines, -1 line
0 comments
Download
M
dfvfs/vfs/tsk_file_entry.py
View
5 chunks
+54 lines, -14 lines
0 comments
Download
M
dfvfs/vfs/tsk_file_system.py
View
3 chunks
+38 lines, -0 lines
0 comments
Download
M
tests/vfs/ntfs_file_entry.py
View
3 chunks
+48 lines, -1 line
0 comments
Download
M
tests/vfs/tsk_file_entry.py
View
2 chunks
+13 lines, -2 lines
0 comments
Download
Messages
Total messages: 4
Expand All Messages
|
Collapse All Messages
Joachim Metz
8 years, 7 months ago (2015-09-06 09:48:58 UTC)
#1
Sign in
to reply to this message.
Joachim Metz
Code updated.
8 years, 7 months ago (2015-09-06 09:51:19 UTC)
#2
Code updated.
Sign in
to reply to this message.
kiddi
LGTM
8 years, 7 months ago (2015-09-14 23:06:12 UTC)
#3
LGTM
Sign in
to reply to this message.
Joachim Metz
Code updated.
8 years, 7 months ago (2015-09-15 05:26:23 UTC)
#4
Code updated.
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 264170043: Initial support for file entry attributes. (Closed)
Created 8 years, 7 months ago by Joachim Metz
Modified 8 years, 7 months ago
Reviewers: kiddi, Joachim Metz, onager
Base URL:
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b