Issue 264020043: check for x11 for the ui too

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 264020043: check for x11 for the ui too (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 8 months ago by fujiwara

Modified:
8 years, 7 months ago

Reviewers:
shawn.p.huang, Peng

CC:
marc-antoine_perennou.com

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

check for x11 for the ui too if built with --enable-ui --disable-xim it currently fails because X11_LIBS is empty BUG=https://github.com/ibus/ibus/pull/1812 R=Shawn.P.Huang@gmail.com Committed: c0ced65ea1298e860c571cd9151d81e620834132

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	configure.ac	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fujiwara

8 years, 7 months ago (2015-09-01 02:20:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c0ced65ea1298e860c571cd9151d81e620834132 (presubmit successful).

Expand All Messages | Collapse All Messages