Issue 26380043: code review 26380043: go.tools/ssa: display named types package-qualified usi...

Issue 26380043: code review 26380043: go.tools/ssa: display named types package-qualified usi... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by adonovan

Modified:
10 years, 5 months ago

Reviewers:
gri1

CC:
gri, gri1, golang-dev

Visibility:
Public.

Description

go.tools/ssa: display named types package-qualified using types.TypeString. Details: - use relative (non-qualified) names in more places - Member interface now has Package(), RelString() methods. - (*Function).DumpTo: add "# Package: " header. - Added sanity checks for String functions.

Patch Set 1 #

Patch Set 2 : diff -r bbfbc0a1f974 https://code.google.com/p/go.tools #

Patch Set 3 : diff -r bbfbc0a1f974 https://code.google.com/p/go.tools #

Total comments: 6

Patch Set 4 : diff -r 6faa19b38832 https://code.google.com/p/go.tools #

Patch Set 5 : diff -r 2d0d531f1e07 https://code.google.com/p/go.tools #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -110 lines)			Patch
M	ssa/const.go	View	1	1 chunk	+13 lines, -7 lines	0 comments	Download
M	ssa/create.go	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	ssa/example_test.go	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
M	ssa/func.go	View	1 2 3 4	7 chunks	+24 lines, -13 lines	0 comments	Download
M	ssa/print.go	View	1 2 3	8 chunks	+27 lines, -60 lines	0 comments	Download
M	ssa/sanity.go	View	1 2 3 4	2 chunks	+9 lines, -0 lines	0 comments	Download
M	ssa/ssa.go	View	1 2 3	6 chunks	+38 lines, -29 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adonovan

Hello gri@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

10 years, 5 months ago (2013-11-14 00:18:56 UTC) #1

gri1

LGTM https://codereview.appspot.com/26380043/diff/30001/ssa/sanity.go File ssa/sanity.go (right): https://codereview.appspot.com/26380043/diff/30001/ssa/sanity.go#newcode371 ssa/sanity.go:371: fn.String() // mustn't crash must not crash https://codereview.appspot.com/26380043/diff/30001/ssa/sanity.go#newcode372 ...

10 years, 5 months ago (2013-11-14 21:38:01 UTC) #2

adonovan

https://codereview.appspot.com/26380043/diff/30001/ssa/sanity.go File ssa/sanity.go (right): https://codereview.appspot.com/26380043/diff/30001/ssa/sanity.go#newcode371 ssa/sanity.go:371: fn.String() // mustn't crash On 2013/11/14 21:38:02, gri1 wrote: ...

10 years, 5 months ago (2013-11-15 14:21:31 UTC) #3

adonovan

10 years, 5 months ago (2013-11-15 14:21:50 UTC) #4

*** Submitted as
https://code.google.com/p/go/source/detail?r=a6bba36a62d5&repo=tools ***

go.tools/ssa: display named types package-qualified using types.TypeString.

Details:
- use relative (non-qualified) names in more places
- Member interface now has Package(), RelString() methods.
- (*Function).DumpTo: add "# Package: " header.
- Added sanity checks for String functions.

R=gri, gri
CC=golang-dev
https://codereview.appspot.com/26380043

Expand All Messages | Collapse All Messages