i#1734 Create Dr. Fuzz: added drwrap callconv flag shift

Commit log for first patchset:
---------------
i#1734 Create Dr. Fuzz: added drwrap callconv flag shift

Added a constant to drwrap.h indicating the shift
offset of the callconv enum within the drwrap flags.
Also updated the release notes to mention the new
callconv support in drwrap.
---------------

[bruening, 2015-10-06 17:15:50]

Without the shift value actually being used by the code, I guess I don't see
this as an improvement.  Perhaps if the actual hex value were in a comment,
though I'm not a fan in general of "1 << N" constructions for bitfields either.

https://codereview.appspot.com/263380043/diff/1/ext/drwrap/drwrap.h
File ext/drwrap/drwrap.h (right):

https://codereview.appspot.com/263380043/diff/1/ext/drwrap/drwrap.h#newcode357
ext/drwrap/drwrap.h:357: DRWRAP_CALLCONV_AMD64          = (1 <<
DRWRAP_CALLCONV_FLAG_SHIFT),
I prefer to have the actual hex value, i.e., how it was before.  It makes
debugging easier and makes it easier, IMHO, to see which bits are used.  In
general, I find the bitfield approach of constructing the value from shifts ends
up obfuscating and making it harder, not easier, for a human to understand.

[Byron, 2015-10-06 22:51:13]

Commit log for latest patchset:
---------------
i#1734 Create Dr. Fuzz: added drwrap callconv flag shift

Added a constant to drwrap.h indicating the shift
offset of the callconv enum within the drwrap flags.
Also updated the release notes to mention the new
callconv support in drwrap.

Review-URL: https://codereview.appspot.com/263380043
---------------

[Byron, 2015-10-06 22:52:38]

https://codereview.appspot.com/263380043/diff/1/ext/drwrap/drwrap.h
File ext/drwrap/drwrap.h (right):

https://codereview.appspot.com/263380043/diff/1/ext/drwrap/drwrap.h#newcode357
ext/drwrap/drwrap.h:357: DRWRAP_CALLCONV_AMD64          = (1 <<
DRWRAP_CALLCONV_FLAG_SHIFT),
On 2015/10/06 17:15:50, bruening wrote:
> I prefer to have the actual hex value, i.e., how it was before.  It makes
> debugging easier and makes it easier, IMHO, to see which bits are used.  In
> general, I find the bitfield approach of constructing the value from shifts
ends
> up obfuscating and making it harder, not easier, for a human to understand.

Done.

[bruening, 2015-10-09 14:35:56]

LGTM

https://codereview.appspot.com/263380043/diff/20001/ext/drwrap/drwrap.h
File ext/drwrap/drwrap.h (right):

https://codereview.appspot.com/263380043/diff/20001/ext/drwrap/drwrap.h#newco...
ext/drwrap/drwrap.h:348: #define DRWRAP_CALLCONV_FLAG_SHIFT 0x18
Is this meant for clients?  Then it needs a doxygen comment.  If not, since
unused, maybe remove?

[Byron, 2015-10-12 07:32:16]

Committed as
https://github.com/DynamoRIO/dynamorio/commit/4c6a59a137e9ed832dc52563ecf4369...

Final commit log: 
---------------
i#1734 Create Dr. Fuzz: added drwrap callconv flag shift

Added a constant to drwrap.h indicating the shift
offset of the callconv enum within the drwrap flags.
Also updated the release notes to mention the new
callconv support in drwrap.

Review-URL: https://codereview.appspot.com/263380043
---------------